Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import pluralize to index.ts #160

Merged
merged 1 commit into from May 5, 2018
Merged

Import pluralize to index.ts #160

merged 1 commit into from May 5, 2018

Conversation

campionfellin
Copy link
Collaborator

@campionfellin campionfellin commented May 5, 2018

This fixes clasp deployments. Somehow the lint missed that we don't import pluralize before running this:

clasp/index.ts

Line 506 in 39e0690

const deploymentWord = pluralize('Deployment', numDeployments);

Which gives an unhandled promise rejection.

This fixes that and should stabilize the build for npm.

Signed-off-by: campionfellin campionfellin@gmail.com

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • npm run test succeeds.
  • npm run lint succeeds.
  • [] Appropriate changes to README are included in PR.

Signed-off-by: campionfellin <campionfellin@gmail.com>
@grant grant merged commit bfe45c4 into master May 5, 2018
@grant grant deleted the quick-fix-for-npm branch May 5, 2018 06:15
@coveralls
Copy link

coveralls commented May 5, 2018

Pull Request Test Coverage Report for Build 149

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 165 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 14.034%

Files with Coverage Reduction New Missed Lines %
index.js 165 6.61%
Totals Coverage Status
Change from base Build 147: 0.07%
Covered Lines: 158
Relevant Lines: 856

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants