Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getAPICredentials so it looks in local RC first then global RC #168

Merged
merged 1 commit into from May 15, 2018
Merged

Fix getAPICredentials so it looks in local RC first then global RC #168

merged 1 commit into from May 15, 2018

Conversation

campionfellin
Copy link
Collaborator

Now, rather than passing a boolean to getAPICredentials of whether you're using local RC, it'll just check there first before moving up to the home dir.

clasp run was the only place it actually passed true, the rest of the commands use nothing (false) and thus is why they didn't pick up on a local RC file.

This will also probably help with testing as well, using Travis with encrypted creds.

Signed-off-by: campionfellin campionfellin@gmail.com

Closes #131

  • npm run test succeeds. (both using clasp login and clasp login --ownkey
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

Signed-off-by: campionfellin <campionfellin@gmail.com>
@coveralls
Copy link

coveralls commented May 15, 2018

Pull Request Test Coverage Report for Build 162

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 14.082%

Files with Coverage Reduction New Missed Lines %
src/auth.js 19 24.07%
Totals Coverage Status
Change from base Build 161: 0.0%
Covered Lines: 163
Relevant Lines: 889

💛 - Coveralls

@grant
Copy link
Contributor

grant commented May 15, 2018

Great! Never liked that dangling true.
We support this style eventually:

const localRC = await DOTFILE.RC_LOCAL.read();

@grant grant merged commit 731e734 into google:master May 15, 2018
@campionfellin campionfellin deleted the api-creds branch May 25, 2018 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants