Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deploy command to inquirer #372

Conversation

takanakahiko
Copy link
Contributor

#57

If you don't input args in clasp deploy, we use inquirer to ask args.

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

@takanakahiko
Copy link
Contributor Author

takanakahiko commented Nov 2, 2018

Processing for selecting a version is duplicated between deploy and redeploy.
I want define this process as function.
Which in file can I define function?

@grant
Copy link
Contributor

grant commented Nov 2, 2018

Thanks!
While you're modifying deploy, can we make it work as such? I think this would be better than inquirer.
#366

OLD

clasp deploy [version] [description]
clasp redeploy [deploymentId] [version] [description]
clasp undeploy <deploymentId>

NEW

clasp deploy [--version=version] [--description=description] [--deploymentId=id]
clasp undeploy [deploymentId]
# redeploy removed

clasp deploy

If we don't provide a version, create a new version.
If we don't provide a description, use a default one.
If we don't provide a deployment, use the latest deployment.

clasp undeploy

If we don't provide a deploymentId, we undeploy the last deployment.

This would be a big enhancement to deploy.

@takanakahiko takanakahiko changed the title Migrate deploy command to inquirer [WIP] Migrate deploy command to inquirer Nov 3, 2018
@takanakahiko
Copy link
Contributor Author

takanakahiko commented Nov 3, 2018

OK, I close this PR once.

@takanakahiko takanakahiko deleted the migrate-deploy-command-to-inquirer branch November 3, 2018 05:38
@takanakahiko takanakahiko restored the migrate-deploy-command-to-inquirer branch November 3, 2018 05:38
@takanakahiko takanakahiko deleted the migrate-deploy-command-to-inquirer branch November 3, 2018 05:39
@takanakahiko takanakahiko restored the migrate-deploy-command-to-inquirer branch November 3, 2018 05:39
@takanakahiko takanakahiko changed the title [WIP] Migrate deploy command to inquirer Migrate deploy command to inquirer Nov 3, 2018
@takanakahiko takanakahiko mentioned this pull request Nov 3, 2018
3 tasks
grant pushed a commit that referenced this pull request Nov 4, 2018
#366 

This PR follows the design of  #372 (comment) .

- [ ] `npm run test` succeeds.
- [x] `npm run lint` succeeds.
- [x] Appropriate changes to README are included in PR.

I am struggling to think of the name of args and I want your idea.
#366 (comment)
grant pushed a commit that referenced this pull request Nov 5, 2018
If you do not enter `deploymentId`, the latest deploymentId will be used.

This PR follows the design of #372 (comment) .

- [ ] `npm run test` succeeds.
- [x] `npm run lint` succeeds.
- [x] Appropriate changes to README are included in PR.
@takanakahiko takanakahiko mentioned this pull request Nov 16, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants