Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inlineSourceMaps for better test coverage checks #515

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

campionfellin
Copy link
Collaborator

General testing improvement... we can now see more accurate coverage numbers and missing lines.

Previously:

screen shot 2019-01-31 at 7 25 43 pm

Now

screen shot 2019-01-31 at 7 23 55 pm

(note this is just one test). We can see now it covers the .ts files instead of .js files.

Signed-off-by: campionfellin campionfellin@gmail.com

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

Signed-off-by: campionfellin <campionfellin@gmail.com>
@grant
Copy link
Contributor

grant commented Feb 1, 2019

But won't this add source maps to the version published to npm? We probably want this tsconfig option just to be applied when testing.

@campionfellin
Copy link
Collaborator Author

I think that should be fine. What would the problem be in publishing source maps to npm?

@grant
Copy link
Contributor

grant commented Feb 1, 2019

I guess it's fine. I thought it would make the build step take longer or add extra bloat.

After a brief search, it seems like it should be fine.
rails/webpacker#769 (comment)

@campionfellin
Copy link
Collaborator Author

Sounds great!

@campionfellin campionfellin merged commit 1cabd67 into google:master Feb 1, 2019
@grant
Copy link
Contributor

grant commented Feb 1, 2019

Also, thanks for the PRs! I sometimes forget to say thanks.

@campionfellin
Copy link
Collaborator Author

Np! It is a good learning opportunity for me!

@campionfellin campionfellin deleted the inline-source-maps branch February 18, 2019 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants