Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip fetching project on create if manifest already exists #6

Merged
merged 2 commits into from Jan 16, 2018
Merged

Skip fetching project on create if manifest already exists #6

merged 2 commits into from Jan 16, 2018

Conversation

sqrrrl
Copy link
Member

@sqrrrl sqrrrl commented Jan 12, 2018

Was trying to add clasp instructions for the gmail add-on samples and noticed that creating a project overwrites the current manifest. For cases where somebody is cloning via git instead of from an apps script project, we shouldn't overwrite things.

Also fixed the license name in the module metadata to avoid warnings from NPM.

@sqrrrl
Copy link
Member Author

sqrrrl commented Jan 12, 2018

Corresponds to issue #5

@grant
Copy link
Contributor

grant commented Jan 15, 2018

LGTM in general, I'll test it once back to work.
Next time, we should make the small license change in a different PR.

Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grant grant merged commit e428501 into google:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants