Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small bits #630

Merged
merged 14 commits into from
May 23, 2019
Merged

Small bits #630

merged 14 commits into from
May 23, 2019

Conversation

PopGoesTheWza
Copy link
Collaborator

Fixes no issues

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

PopGoesTheWza and others added 13 commits May 14, 2019 00:03
@PopGoesTheWza
Merge pull request #17 from google/master
5bdc1b4 
use forEach instead of map when return value is not used (google#614)
@PopGoesTheWza
Merge pull request #18 from google/master
ed24bb7 
Dependencies (google#615)
@grant @PopGoesTheWza
2.1.0
807729c
@PopGoesTheWza
Low impact changes (google#619)
83b9e78 
* dependencies clean-up

* types for child_process' spawnSync

* types for child_process' spawnSync + options fix

* linting
@PopGoesTheWza
Relative rootdir (google#620)
a89ab84 
* relative rootDir support

* relative rootDir support (untrackedFiles behavior changed)

* relative rootDir doc changes
@PopGoesTheWza
Cleanup before next pr (google#621)
19a2fd6 
* prettier + sort imports

* splitLines types

* unused package 'connect'

* ucfirst, isOnline types

* ellipsize types

* redundant package 'fs-copy-file-sync'

* removing extra line

* // TODO

* packages dependencies update

* comment fix

* fixes

* nicer ellipsize typing

* better?
@PopGoesTheWza
Refactor inquirer package (google#622)
2abec30 
* regroup `inquirer` into a single file

* fix typo

* linting

* switch to `find-up`

* switch to `find-up` & `strip-bom`

* dependencies update

* findUp implementation fix

* enum accessor fix

* fs-extra & typescript dependency fix

* linting

* dependencies clean-up (again)

* non any cast
@PopGoesTheWza
Merge branch 'master' of https://github.com/google/clasp
4829c18
@PopGoesTheWza
TODOs & types
11b7e0a
@PopGoesTheWza
Merge branch 'master' of https://github.com/google/clasp into small-bits
fd7b50e
@PopGoesTheWza
dependencies
ef2a4a3
@PopGoesTheWza
relative paths fix
0dc7a81
@PopGoesTheWza
relative paths fix, types & minor code changes
f6e7532
grant
grant reviewed May 23, 2019
View reviewed changes
src/dotfile.ts Show resolved Hide resolved
grant
grant reviewed May 23, 2019
View reviewed changes
src/inquirer.ts Show resolved Hide resolved
src/auth.ts Outdated Show resolved Hide resolved
@grant grant merged commit 7c38877 into google:master May 23, 2019
@grant
Copy link
Contributor

grant commented May 23, 2019

Thank you.

@PopGoesTheWza PopGoesTheWza deleted the small-bits branch May 23, 2019 22:47
@sloba88
Copy link

sloba88 commented May 24, 2019

There seem to be some issue with dotf now

clasp
/usr/local/lib/node_modules/@google/clasp/src/dotfile.js:89
    RC: dotf(exports.DOT.RC.DIR, exports.DOT.RC.NAME),
        ^

TypeError: dotf is not a function
    at Object.<anonymous> (/usr/local/lib/node_modules/@google/clasp/src/dotfile.js:89:9)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/usr/local/lib/node_modules/@google/clasp/src/auth.js:57:17)
    at Module._compile (module.js:653:30)

@PopGoesTheWza
Copy link
Collaborator Author

@sloba88 It looks like dotf@1.3.0 package is broken.

Temporary workaround is to edit Clasp's package.json until @grant and I fix this mistake

    "dotf": "~1.2.0",

@PopGoesTheWza
Copy link
Collaborator Author

@sloba88 please follow-up on #631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grant grant grant left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PopGoesTheWza @grant @sloba88 @googlebot