Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc tsconfig 561 #644

Merged
merged 14 commits into from
Jun 14, 2019
Merged

Doc tsconfig 561 #644

merged 14 commits into from
Jun 14, 2019

Conversation

PopGoesTheWza
Copy link
Collaborator

Fixes #561

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

PopGoesTheWza and others added 13 commits May 14, 2019 00:03
use forEach instead of map when return value is not used (google#614)
* dependencies clean-up

* types for child_process' spawnSync

* types for child_process' spawnSync + options fix

* linting
* relative rootDir support

* relative rootDir support (untrackedFiles behavior changed)

* relative rootDir doc changes
* prettier + sort imports

* splitLines types

* unused package 'connect'

* ucfirst, isOnline types

* ellipsize types

* redundant package 'fs-copy-file-sync'

* removing extra line

* // TODO

* packages dependencies update

* comment fix

* fixes

* nicer ellipsize typing

* better?
* regroup `inquirer` into a single file

* fix typo

* linting

* switch to `find-up`

* switch to `find-up` & `strip-bom`

* dependencies update

* findUp implementation fix

* enum accessor fix

* fs-extra & typescript dependency fix

* linting

* dependencies clean-up (again)

* non any cast
docs/typescript.md Outdated Show resolved Hide resolved
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the comments, change, then I'll merge.

docs/typescript.md Outdated Show resolved Hide resolved
docs/typescript.md Outdated Show resolved Hide resolved
@grant grant merged commit a7c04dc into google:master Jun 14, 2019
@grant
Copy link
Contributor

grant commented Jun 14, 2019

Thank you for the contribution @PopGoesTheWza!

@PopGoesTheWza PopGoesTheWza deleted the doc-tsconfig-561 branch June 14, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document tsconfig.json support
3 participants