Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 666 #667

Merged
merged 24 commits into from
Aug 1, 2019
Merged

Issue 666 #667

merged 24 commits into from
Aug 1, 2019

Conversation

PopGoesTheWza
Copy link
Collaborator

(Tentatively) Fixes #666

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

PopGoesTheWza and others added 23 commits May 14, 2019 00:03
use forEach instead of map when return value is not used (google#614)
* dependencies clean-up

* types for child_process' spawnSync

* types for child_process' spawnSync + options fix

* linting
* relative rootDir support

* relative rootDir support (untrackedFiles behavior changed)

* relative rootDir doc changes
* prettier + sort imports

* splitLines types

* unused package 'connect'

* ucfirst, isOnline types

* ellipsize types

* redundant package 'fs-copy-file-sync'

* removing extra line

* // TODO

* packages dependencies update

* comment fix

* fixes

* nicer ellipsize typing

* better?
* regroup `inquirer` into a single file

* fix typo

* linting

* switch to `find-up`

* switch to `find-up` & `strip-bom`

* dependencies update

* findUp implementation fix

* enum accessor fix

* fs-extra & typescript dependency fix

* linting

* dependencies clean-up (again)

* non any cast
@grant grant merged commit be6515a into google:master Aug 1, 2019
@PopGoesTheWza PopGoesTheWza deleted the issue-666 branch August 1, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "manifestHasChanges" function shouldn't check the line endings
3 participants