Migrate from watch to chokidar #843
Conversation
src/commands/push.ts
Outdated
| }; | ||
| const watcher = chokidar.watch(rootDir, {persistent: true, awaitWriteFinish: true, ignoreInitial: true}); | ||
| watcher.on('ready', pushFiles); // Push on start | ||
| watcher.on('all', watchCallback); |
There was a problem hiding this comment.
Not sure events like addDir and unlinkDir are worth processing for they relate to folder events. Inside watchCallback I filter and keep only add, change and unlink events (or register watchCallback only for those .on() events)
There was a problem hiding this comment.
Done. In practice, it's not much of an issue since default clasp ignore settings ends up filtering out directories. In any case, changed it to just add/change/unlink + added debouncing to handle 'save all' type actions in IDEs so the events get coalesced into a single push.
There was a problem hiding this comment.
Seeing how you added debounce, I guess you use/test the watch feature. There's just too much I did refactor without thoroughly testing it.
|
LGTM |
Fixes #841.
npm run testsucceeds.npm run lintsucceeds.