Support arm64 on darwin

[domoritz]

It would be great if you could support ARM64 (Apple M1) for the OSX bundles.

[ChadKillingsworth]

Will be quite a while before that is possible. Graal has to support building in that environment and we would need an automated build system that supports M1 macs.

[domoritz]

Is that oracle/graal#2666?

[ChadKillingsworth]

That looks correct for the Graal support. But we would still need a build environment. GitHub Actions doesn't support M1 macs right now.

[domoritz]

The relevant issue for that is actions/runner-images#2187, I believe.

[ChadKillingsworth]

We can probably add arm64 to the architecture though and let Rosetta handle the translation for now. Would you be able to test that the current image actually works? I don't have an M1 Mac to try this on.

[domoritz]

Yes, I'd be happy to give it a try. Would you make a prerelease that I can install or a branch?

[ChadKillingsworth]

You can download the MacOS image binary from any of the CI build runs such as https://github.com/google/closure-compiler-npm/actions/runs/860306976

You just need to see if the binary will execute. So compiler --help should do it.

[domoritz]

I downloaded the binary, marked it as executable, allowed it in the macOS security settings and ran ./compiler --help without problems.

$ arch
arm64
$ lipo -info compiler
Non-fat file: compiler is architecture: x86_64

So looks like it should just work.

[domoritz]

@ChadKillingsworth anything else I can test before you make a release?

[ChadKillingsworth]

I created the pr.

[domoritz]

Thank you. I made a similar pull request in #215.

[ChadKillingsworth]

Awe sorry - I missed that one.

[ChadKillingsworth]

You should be able to test this tomorrow with the nightly build

[domoritz]

Thanks for merging. I totally forgot to mention it here. Looking forward to trying the new version.