Rename recordInvalidations to withInvalidationMap.

The name recordInvalidations implies that the class should pass a non-empty map of invalidations which will be recorded. In fact, when this is called, the caller passes a mutable empty map, which the Builder later uses to record invalidations.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=191763716

src/com/google/javascript/jscomp/DisambiguateProperties.java

@@ -337,7 +337,7 @@ boolean scheduleRenaming(Node node, TypeI type) {
     this.invalidationMap = propertiesToErrorFor.isEmpty() ? null : LinkedHashMultimap.create();
 
     this.invalidatingTypes = new InvalidatingTypes.Builder(registry)
-        .recordInvalidations(this.invalidationMap)
+        .writeInvalidationsInto(this.invalidationMap)
         .addTypesInvalidForPropertyRenaming()
         .addAllTypeMismatches(compiler.getTypeMismatches())
         .addAllTypeMismatches(compiler.getImplicitInterfaceUses())

src/com/google/javascript/jscomp/InvalidatingTypes.java

@@ -91,7 +91,7 @@ InvalidatingTypes build() {
     // TODO(sdh): Investigate whether this can be consolidated between all three passes.
     // In particular, mutation testing suggests allowEnums=true should work everywhere.
     // We should revisit what breaks when we disallow scalars everywhere.
-    Builder recordInvalidations(@Nullable Multimap<TypeI, Supplier<JSError>> invalidationMap) {
+    Builder writeInvalidationsInto(@Nullable Multimap<TypeI, Supplier<JSError>> invalidationMap) {
       this.invalidationMap = invalidationMap;
       return this;
     }