Skip to content

Commit

Permalink
Roll RemoveUnusedPolyfills into RemoveUnusedCode
Browse files Browse the repository at this point in the history
By taking advantage of RemoveUnusedCode's better logic, we are able to do significantly better removal than we could before (in particular, removing the Set polyfill no longer leaves the Map and WeakMap polyfills behind).  This introduces a direct dependency on type information into RemoveUnusedCode where previously it relied entirely on disambiguation for type awareness.  Without type information, polyfills may still be removed, but the accuracy is poorer (unused polyfills may not be removed, and used polyfills that are hidden on aliases may be incorrectly removed).

This CL does not actually switch over to the new logic in DefaultPassConfig yet.  We will do that in a follow-up CL to minimize the size of potentially breaking changes in case of rollbacks.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=225476066
  • Loading branch information
shicks authored and blickly committed Dec 15, 2018
1 parent a8c1fe4 commit 1f820b5
Show file tree
Hide file tree
Showing 3 changed files with 1,130 additions and 20 deletions.

0 comments on commit 1f820b5

Please sign in to comment.