Clean up NewTypeInferenceTestBase & related tests

1. setUp() should always call super.setUp() & declare 'throws Exception'
2. Don't call setUp() from any method. Provide a method to explicitly create a
   fresh compiler instead.
4. Rename 'getOptions()' to 'getDefaultOptions()' to make it clearer that it doesn't
   just fetch the options object out of the compiler.
2. Make it easy to modify compiler options for individual test cases.
3. Make "passes" a local variable.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=127739917

test/com/google/javascript/jscomp/CompilerTypeTestCase.java

@@ -66,7 +66,7 @@ abstract class CompilerTypeTestCase extends BaseJSTypeTestCase {
 
   protected Compiler compiler;
 
-  protected CompilerOptions getOptions() {
+  protected CompilerOptions getDefaultOptions() {
     CompilerOptions options = new CompilerOptions();
     options.setLanguageIn(LanguageMode.ECMASCRIPT5);
     options.setWarningLevel(
@@ -102,9 +102,14 @@ protected void checkReportedWarningsHelper(String[] expected) {
   }
 
   @Override
-  protected void setUp() {
+  protected void setUp() throws Exception {
+    super.setUp();
+    initializeNewCompiler(getDefaultOptions());
+  }
+
+  protected void initializeNewCompiler(CompilerOptions options) {
     compiler = new Compiler();
-    compiler.initOptions(getOptions());
+    compiler.initOptions(options);
     registry = compiler.getTypeRegistry();
     initTypes();
   }

test/com/google/javascript/jscomp/LinkedFlowScopeTest.java

@@ -40,7 +40,7 @@ public final class LinkedFlowScopeTest extends CompilerTypeTestCase {
   private FlowScope localEntry;
 
   @Override
-  public void setUp() {
+  public void setUp() throws Exception {
     super.setUp();
 
     globalScope = TypedScope.createGlobalScope(blockNode);

test/com/google/javascript/jscomp/NewTypeInferenceTest.java

@@ -16656,7 +16656,7 @@ public void testSimpleInferPrototypeProperties() {
   }
 
   public void testReportUknownTypes() {
-    this.reportUnknownTypes = true;
+    compilerOptions.setWarningLevel(DiagnosticGroups.REPORT_UNKNOWN_TYPES, CheckLevel.WARNING);
 
     typeCheck(
         "var x = globalvar;",

test/com/google/javascript/jscomp/NewTypeInferenceTestBase.java

@@ -18,6 +18,7 @@
 
 import com.google.common.base.Joiner;
 import com.google.common.collect.ImmutableList;
+import com.google.javascript.jscomp.CompilerOptions.LanguageMode;
 import com.google.javascript.rhino.IR;
 import com.google.javascript.rhino.InputId;
 import com.google.javascript.rhino.Node;
@@ -32,8 +33,8 @@
  * @author dimvar@google.com (Dimitris Vardoulakis)
  */
 public abstract class NewTypeInferenceTestBase extends CompilerTypeTestCase {
-  private List<PassFactory> passes;
-  protected boolean reportUnknownTypes;
+
+  protected CompilerOptions compilerOptions;
 
   protected static final String CLOSURE_BASE =
       LINE_JOINER.join(
@@ -170,14 +171,21 @@ public abstract class NewTypeInferenceTestBase extends CompilerTypeTestCase {
           "");
 
   @Override
-  protected void setUp() {
+  protected void setUp() throws Exception {
     super.setUp();
-    this.passes = new ArrayList<>();
+    compilerOptions = getDefaultOptions();
   }
 
   @Override
-  protected void tearDown() {
-    this.reportUnknownTypes = false;
+  protected CompilerOptions getDefaultOptions() {
+    CompilerOptions compilerOptions = super.getDefaultOptions();
+    compilerOptions.setClosurePass(true);
+    compilerOptions.setNewTypeInference(true);
+    compilerOptions.setWarningLevel(
+        DiagnosticGroups.NEW_CHECK_TYPES_ALL_CHECKS, CheckLevel.WARNING);
+    // EC5 is the highest language level that type inference understands.
+    compilerOptions.setLanguage(LanguageMode.ECMASCRIPT5);
+    return compilerOptions;
   }
 
   protected final PassFactory makePassFactory(
@@ -191,23 +199,11 @@ protected CompilerPass create(AbstractCompiler compiler) {
   }
 
   private final void parseAndTypeCheck(String externs, String js) {
-    // NOTE(dimvar): it's unusual that we run setUp for each test in a test
-    // method rather than once per test method. But the parent class creates a
-    // new compiler object at every setUp call, and we need that.
-    setUp();
-    final CompilerOptions options = compiler.getOptions();
-    options.setClosurePass(true);
-    options.setNewTypeInference(true);
-    options.setWarningLevel(
-        DiagnosticGroups.NEW_CHECK_TYPES_ALL_CHECKS, CheckLevel.WARNING);
-    if (this.reportUnknownTypes) {
-      options.setWarningLevel(
-          DiagnosticGroups.REPORT_UNKNOWN_TYPES, CheckLevel.WARNING);
-    }
+    initializeNewCompiler(compilerOptions);
     compiler.init(
         ImmutableList.of(SourceFile.fromCode("[externs]", externs)),
         ImmutableList.of(SourceFile.fromCode("[testcode]", js)),
-        options);
+        compilerOptions);
 
     Node externsRoot = IR.block();
     externsRoot.setIsSyntheticBlock(true);
@@ -233,15 +229,17 @@ private final void parseAndTypeCheck(String externs, String js) {
 
     DeclaredGlobalExternsOnWindow rewriteExterns =
         new DeclaredGlobalExternsOnWindow(compiler);
+    List<PassFactory> passes = new ArrayList<>();
     passes.add(makePassFactory("globalExternsOnWindow", rewriteExterns));
     ProcessClosurePrimitives closurePass =
         new ProcessClosurePrimitives(compiler, null, CheckLevel.ERROR, false);
     passes.add(makePassFactory("ProcessClosurePrimitives", closurePass));
-    if (options.getLanguageIn() == CompilerOptions.LanguageMode.ECMASCRIPT6_TYPED) {
+    if (compilerOptions.getLanguageIn() == LanguageMode.ECMASCRIPT6_TYPED) {
       passes.add(makePassFactory("convertEs6TypedToEs6",
               new Es6TypedToEs6Converter(compiler)));
     }
-    if (options.getLanguageIn().isEs6OrHigher()) {
+    if (compilerOptions.getLanguageIn().isEs6OrHigher()
+        && !compilerOptions.getLanguageOut().isEs6OrHigher()) {
       TranspilationPasses.addEs6EarlyPasses(passes);
       TranspilationPasses.addEs6LatePasses(passes);
     }

test/com/google/javascript/jscomp/NewTypeInferenceWithTranspilationTest.java

@@ -29,9 +29,10 @@
 public final class NewTypeInferenceWithTranspilationTest extends NewTypeInferenceTestBase {
 
   @Override
-  protected void setUp() {
+  protected void setUp() throws Exception {
     super.setUp();
-    compiler.getOptions().setLanguageIn(LanguageMode.ECMASCRIPT6);
+    compilerOptions.setLanguageIn(LanguageMode.ECMASCRIPT6);
+    compilerOptions.setLanguageOut(LanguageMode.ECMASCRIPT3);
   }
 
   public void testSimpleClasses() {

test/com/google/javascript/jscomp/NewTypeInferenceWithTypeSyntaxTranspilationTest.java

@@ -34,9 +34,10 @@ public final class NewTypeInferenceWithTypeSyntaxTranspilationTest
     extends NewTypeInferenceTestBase {
 
   @Override
-  protected void setUp() {
+  protected void setUp() throws Exception {
     super.setUp();
-    compiler.getOptions().setLanguageIn(LanguageMode.ECMASCRIPT6_TYPED);
+    compilerOptions.setLanguageIn(LanguageMode.ECMASCRIPT6_TYPED);
+    compilerOptions.setLanguageOut(LanguageMode.ECMASCRIPT3);
   }
 
   public void testSimpleAnnotationsNoWarnings() {
@@ -214,6 +215,8 @@ public void testAmbientDeclarationsInCode() {
   }
 
   public void testGetterReturnNonDeclaredType() {
+    // getters cannot be transpiled to EC3
+    compilerOptions.setLanguageOut(LanguageMode.ECMASCRIPT5);
     typeCheck(
         "var x = {get a(): number { return 'str'; }}",
         NewTypeInference.RETURN_NONDECLARED_TYPE);

test/com/google/javascript/jscomp/PolymerBehaviorExtractorTest.java

@@ -31,7 +31,7 @@ public class PolymerBehaviorExtractorTest extends CompilerTypeTestCase {
   private Node behaviorArray;
 
   @Override
-  protected void setUp() {
+  protected void setUp() throws Exception {
     super.setUp();
     behaviorArray = null;
   }

test/com/google/javascript/jscomp/PolymerClassDefinitionTest.java

@@ -25,7 +25,7 @@ public final class PolymerClassDefinitionTest extends CompilerTypeTestCase {
   private Node polymerCall;
 
   @Override
-  protected void setUp() {
+  protected void setUp() throws Exception {
     super.setUp();
     polymerCall = null;
   }

test/com/google/javascript/jscomp/PolymerClassRewriterTest.java

@@ -60,7 +60,7 @@ public final class PolymerClassRewriterTest extends CompilerTypeTestCase {
   private Node polymerCall;
 
   @Override
-  protected void setUp() {
+  protected void setUp() throws Exception {
     super.setUp();
     polymerCall = null;
     rootNode = null;
@@ -116,7 +116,7 @@ public void testPathAssignmentTarget() {
   }
 
   @Override
-  protected CompilerOptions getOptions() {
+  protected CompilerOptions getDefaultOptions() {
     CompilerOptions options = new CompilerOptions();
     options.setLanguageIn(LanguageMode.ECMASCRIPT5);
     options.setWarningLevel(

test/com/google/javascript/jscomp/SemanticReverseAbstractInterpreterTest.java

@@ -33,7 +33,7 @@ public final class SemanticReverseAbstractInterpreterTest
   private TypedScope functionScope;
 
   @Override
-  protected void setUp() {
+  protected void setUp() throws Exception {
     super.setUp();
 
     interpreter = new SemanticReverseAbstractInterpreter(registry);

test/com/google/javascript/jscomp/TypeCheckTest.java

@@ -56,7 +56,7 @@ public final class TypeCheckTest extends CompilerTypeTestCase {
       + " make sure to give it a type.)";
 
   @Override
-  public void setUp() {
+  public void setUp() throws Exception {
     super.setUp();
   }
 

test/com/google/javascript/jscomp/TypeTransformationTest.java

@@ -39,7 +39,7 @@ public final class TypeTransformationTest extends CompilerTypeTestCase {
           + "var n = 10;";
 
   @Override
-  public void setUp() {
+  public void setUp() throws Exception {
     super.setUp();
     errorReporter = new TestErrorReporter(null, null);
     initRecordTypeTests();