Skip to content

Commit

Permalink
Rename traverseEs6 to traverse (and similarly with other methods with…
Browse files Browse the repository at this point in the history
… "Es6" in the name.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=192698297
  • Loading branch information
tbreisacher authored and tjgq committed Apr 14, 2018
1 parent 8ae754b commit 4c97e69
Show file tree
Hide file tree
Showing 173 changed files with 350 additions and 345 deletions.
2 changes: 1 addition & 1 deletion src/com/google/javascript/jscomp/AliasStrings.java
Expand Up @@ -116,7 +116,7 @@ public void process(Node externs, Node root) {
logger.fine("Aliasing common strings"); logger.fine("Aliasing common strings");


// Traverse the tree and collect strings // Traverse the tree and collect strings
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);


// 1st edit pass: replace some strings with aliases // 1st edit pass: replace some strings with aliases
replaceStringsWithAliases(); replaceStringsWithAliases();
Expand Down
2 changes: 1 addition & 1 deletion src/com/google/javascript/jscomp/AmbiguateProperties.java
Expand Up @@ -176,7 +176,7 @@ private int getIntForType(TypeI type) {
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
// Find all property references and record the types on which they occur. // Find all property references and record the types on which they occur.
// Populate stringNodesToRename, propertyMap, quotedNames. // Populate stringNodesToRename, propertyMap, quotedNames.
NodeTraversal.traverseEs6(compiler, root, new ProcessProperties()); NodeTraversal.traverse(compiler, root, new ProcessProperties());


ImmutableSet.Builder<String> reservedNames = ImmutableSet.<String>builder() ImmutableSet.Builder<String> reservedNames = ImmutableSet.<String>builder()
.addAll(externedNames) .addAll(externedNames)
Expand Down
Expand Up @@ -151,11 +151,11 @@ class AnalyzePrototypeProperties implements CompilerPass {
public void process(Node externRoot, Node root) { public void process(Node externRoot, Node root) {
checkState(compiler.getLifeCycleStage().isNormalized()); checkState(compiler.getLifeCycleStage().isNormalized());
if (!canModifyExterns) { if (!canModifyExterns) {
NodeTraversal.traverseEs6(compiler, externRoot, NodeTraversal.traverse(compiler, externRoot,
new ProcessExternProperties()); new ProcessExternProperties());
} }


NodeTraversal.traverseEs6(compiler, root, new ProcessProperties()); NodeTraversal.traverse(compiler, root, new ProcessProperties());


FixedPointGraphTraversal<NameInfo, JSModule> t = FixedPointGraphTraversal<NameInfo, JSModule> t =
FixedPointGraphTraversal.newTraversal(new PropagateReferences()); FixedPointGraphTraversal.newTraversal(new PropagateReferences());
Expand Down
2 changes: 1 addition & 1 deletion src/com/google/javascript/jscomp/AngularPass.java
Expand Up @@ -115,7 +115,7 @@ public void process(Node externs, Node root) {
@Override @Override
public void hotSwapScript(Node scriptRoot, Node originalRoot) { public void hotSwapScript(Node scriptRoot, Node originalRoot) {
// Traverses AST looking for nodes annotated with @ngInject. // Traverses AST looking for nodes annotated with @ngInject.
NodeTraversal.traverseEs6(compiler, scriptRoot, this); NodeTraversal.traverse(compiler, scriptRoot, this);
// iterates through annotated nodes adding $inject property to elements. // iterates through annotated nodes adding $inject property to elements.
for (NodeContext entry : injectables) { for (NodeContext entry : injectables) {
String name = entry.getName(); String name = entry.getName();
Expand Down
6 changes: 3 additions & 3 deletions src/com/google/javascript/jscomp/CheckAccessControls.java
Expand Up @@ -157,8 +157,8 @@ public void process(Node externs, Node root) {
collectPass.process(externs, root); collectPass.process(externs, root);
defaultVisibilityForFiles = collectPass.getFileOverviewVisibilityMap(); defaultVisibilityForFiles = collectPass.getFileOverviewVisibilityMap();


NodeTraversal.traverseEs6(compiler, externs, this); NodeTraversal.traverse(compiler, externs, this);
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
} }


@Override @Override
Expand All @@ -168,7 +168,7 @@ public void hotSwapScript(Node scriptRoot, Node originalRoot) {
collectPass.hotSwapScript(scriptRoot, originalRoot); collectPass.hotSwapScript(scriptRoot, originalRoot);
defaultVisibilityForFiles = collectPass.getFileOverviewVisibilityMap(); defaultVisibilityForFiles = collectPass.getFileOverviewVisibilityMap();


NodeTraversal.traverseEs6(compiler, scriptRoot, this); NodeTraversal.traverse(compiler, scriptRoot, this);
} }


@Override @Override
Expand Down
2 changes: 1 addition & 1 deletion src/com/google/javascript/jscomp/CheckConformance.java
Expand Up @@ -79,7 +79,7 @@ public static interface Rule {
@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
if (!rules.isEmpty()) { if (!rules.isEmpty()) {
NodeTraversal.traverseRootsEs6(compiler, this, externs, root); NodeTraversal.traverseRoots(compiler, this, externs, root);
} }
} }


Expand Down
Expand Up @@ -47,12 +47,12 @@ class CheckConstPrivateProperties extends NodeTraversal.AbstractPostOrderCallbac


@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
} }


@Override @Override
public void hotSwapScript(Node scriptRoot, Node originalRoot) { public void hotSwapScript(Node scriptRoot, Node originalRoot) {
NodeTraversal.traverseEs6(compiler, scriptRoot, this); NodeTraversal.traverse(compiler, scriptRoot, this);
} }


/** Reports the property definitions that should use the @const annotation. */ /** Reports the property definitions that should use the @const annotation. */
Expand Down
Expand Up @@ -42,7 +42,7 @@ public CheckDebuggerStatement(AbstractCompiler compiler) {


@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
} }


@Override @Override
Expand Down
6 changes: 3 additions & 3 deletions src/com/google/javascript/jscomp/CheckJSDoc.java
Expand Up @@ -87,13 +87,13 @@ final class CheckJSDoc extends AbstractPostOrderCallback implements HotSwapCompi


@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
NodeTraversal.traverseEs6(compiler, externs, this); NodeTraversal.traverse(compiler, externs, this);
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
} }


@Override @Override
public void hotSwapScript(Node scriptRoot, Node originalRoot) { public void hotSwapScript(Node scriptRoot, Node originalRoot) {
NodeTraversal.traverseEs6(compiler, scriptRoot, this); NodeTraversal.traverse(compiler, scriptRoot, this);
} }


@Override @Override
Expand Down
Expand Up @@ -116,7 +116,7 @@ static enum Mode {
@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
reset(); reset();
NodeTraversal.traverseRootsEs6(compiler, this, externs, root); NodeTraversal.traverseRoots(compiler, this, externs, root);
} }


@Override @Override
Expand All @@ -125,7 +125,7 @@ public void hotSwapScript(Node scriptRoot, Node originalRoot) {
// b/28869281 for context. // b/28869281 for context.
mode = Mode.SINGLE_FILE; mode = Mode.SINGLE_FILE;
reset(); reset();
NodeTraversal.traverseEs6(compiler, scriptRoot, this); NodeTraversal.traverse(compiler, scriptRoot, this);
} }


// Return true if the name is a class name (starts with an uppercase // Return true if the name is a class name (starts with an uppercase
Expand Down
Expand Up @@ -53,7 +53,7 @@ class CheckMissingGetCssName


@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
} }


@Override @Override
Expand Down
2 changes: 1 addition & 1 deletion src/com/google/javascript/jscomp/CheckProvides.java
Expand Up @@ -49,7 +49,7 @@ public void process(Node externs, Node root) {
public void hotSwapScript(Node scriptRoot, Node originalRoot) { public void hotSwapScript(Node scriptRoot, Node originalRoot) {
CheckProvidesCallback callback = CheckProvidesCallback callback =
new CheckProvidesCallback(codingConvention); new CheckProvidesCallback(codingConvention);
NodeTraversal.traverseEs6(compiler, scriptRoot, callback); NodeTraversal.traverse(compiler, scriptRoot, callback);
} }


private class CheckProvidesCallback extends AbstractShallowCallback { private class CheckProvidesCallback extends AbstractShallowCallback {
Expand Down
2 changes: 1 addition & 1 deletion src/com/google/javascript/jscomp/CheckRegExp.java
Expand Up @@ -78,7 +78,7 @@ public CheckRegExp(AbstractCompiler compiler) {


@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
} }


@Override @Override
Expand Down
8 changes: 4 additions & 4 deletions src/com/google/javascript/jscomp/CheckSideEffects.java
Expand Up @@ -65,9 +65,9 @@ final class CheckSideEffects extends AbstractPostOrderCallback


@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
NodeTraversal.traverseEs6(compiler, externs, new GetNoSideEffectExterns()); NodeTraversal.traverse(compiler, externs, new GetNoSideEffectExterns());


NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);


// Code with hidden side-effect code is common, for example // Code with hidden side-effect code is common, for example
// accessing "el.offsetWidth" forces a reflow in browsers, to allow this // accessing "el.offsetWidth" forces a reflow in browsers, to allow this
Expand All @@ -82,7 +82,7 @@ public void process(Node externs, Node root) {


@Override @Override
public void hotSwapScript(Node scriptRoot, Node originalRoot) { public void hotSwapScript(Node scriptRoot, Node originalRoot) {
NodeTraversal.traverseEs6(compiler, scriptRoot, this); NodeTraversal.traverse(compiler, scriptRoot, this);
} }


@Override @Override
Expand Down Expand Up @@ -210,7 +210,7 @@ static class StripProtection extends AbstractPostOrderCallback implements Compil


@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
} }


@Override @Override
Expand Down
6 changes: 3 additions & 3 deletions src/com/google/javascript/jscomp/CheckSuper.java
Expand Up @@ -44,12 +44,12 @@ public CheckSuper(AbstractCompiler compiler) {


@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
} }


@Override @Override
public void hotSwapScript(Node scriptRoot, Node originalRoot) { public void hotSwapScript(Node scriptRoot, Node originalRoot) {
NodeTraversal.traverseEs6(compiler, scriptRoot, this); NodeTraversal.traverse(compiler, scriptRoot, this);
} }


@Override @Override
Expand Down Expand Up @@ -83,7 +83,7 @@ private boolean visitClass(NodeTraversal t, Node n) {
} }


FindSuper finder = new FindSuper(); FindSuper finder = new FindSuper();
NodeTraversal.traverseEs6(compiler, NodeUtil.getFunctionBody(constructor), finder); NodeTraversal.traverse(compiler, NodeUtil.getFunctionBody(constructor), finder);


if (!finder.found) { if (!finder.found) {
t.report(constructor, MISSING_CALL_TO_SUPER); t.report(constructor, MISSING_CALL_TO_SUPER);
Expand Down
Expand Up @@ -55,12 +55,12 @@ class CheckUnusedPrivateProperties


@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
} }


@Override @Override
public void hotSwapScript(Node scriptRoot, Node originalRoot) { public void hotSwapScript(Node scriptRoot, Node originalRoot) {
NodeTraversal.traverseEs6(compiler, scriptRoot, this); NodeTraversal.traverse(compiler, scriptRoot, this);
} }


private void reportUnused(NodeTraversal t) { private void reportUnused(NodeTraversal t) {
Expand Down
4 changes: 2 additions & 2 deletions src/com/google/javascript/jscomp/ChromePass.java
Expand Up @@ -113,7 +113,7 @@ public ChromePass(AbstractCompiler compiler) {


@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
} }


@Override @Override
Expand Down Expand Up @@ -352,7 +352,7 @@ private void visitNamespaceDefinition(Node crDefineCallNode, Node parent) {


Map<String, String> exports = objectLitToMap(objectLit); Map<String, String> exports = objectLitToMap(objectLit);


NodeTraversal.traverseEs6( NodeTraversal.traverse(
compiler, compiler,
functionBlock, functionBlock,
new RenameInternalsToExternalsCallback(namespace, exports, functionBlock)); new RenameInternalsToExternalsCallback(namespace, exports, functionBlock));
Expand Down
4 changes: 2 additions & 2 deletions src/com/google/javascript/jscomp/ClosureCheckModule.java
Expand Up @@ -186,12 +186,12 @@ public ClosureCheckModule(AbstractCompiler compiler) {


@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
} }


@Override @Override
public void hotSwapScript(Node scriptRoot, Node originalRoot) { public void hotSwapScript(Node scriptRoot, Node originalRoot) {
NodeTraversal.traverseEs6(compiler, scriptRoot, this); NodeTraversal.traverse(compiler, scriptRoot, this);
} }


@Override @Override
Expand Down
Expand Up @@ -87,7 +87,7 @@ public void visit(NodeTraversal t, Node n, Node parent) {
@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
FindPrimitives pass = new FindPrimitives(); FindPrimitives pass = new FindPrimitives();
NodeTraversal.traverseEs6(compiler, root, pass); NodeTraversal.traverse(compiler, root, pass);
} }


/** /**
Expand Down
4 changes: 2 additions & 2 deletions src/com/google/javascript/jscomp/ClosureRewriteClass.java
Expand Up @@ -103,7 +103,7 @@ public void process(Node externs, Node root) {


@Override @Override
public void hotSwapScript(Node scriptRoot, Node originalRoot) { public void hotSwapScript(Node scriptRoot, Node originalRoot) {
NodeTraversal.traverseEs6(compiler, scriptRoot, this); NodeTraversal.traverse(compiler, scriptRoot, this);
} }


@Override @Override
Expand Down Expand Up @@ -498,7 +498,7 @@ private void rewriteGoogDefineClass(NodeTraversal t, Node exprRoot, final ClassD
Node argList = cls.classModifier.getSecondChild(); Node argList = cls.classModifier.getSecondChild();
Node arg = argList.getFirstChild(); Node arg = argList.getFirstChild();
final String argName = arg.getString(); final String argName = arg.getString();
NodeTraversal.traverseEs6( NodeTraversal.traverse(
compiler, compiler,
cls.classModifier.getLastChild(), cls.classModifier.getLastChild(),
new AbstractPostOrderCallback() { new AbstractPostOrderCallback() {
Expand Down
16 changes: 8 additions & 8 deletions src/com/google/javascript/jscomp/ClosureRewriteModule.java
Expand Up @@ -701,7 +701,7 @@ private void processAllFiles(Deque<ScriptDescription> scriptDescriptions, Node s
if (scriptParent == null) { if (scriptParent == null) {
return; return;
} }
NodeTraversal.traverseEs6(compiler, scriptParent, new UnwrapGoogLoadModule()); NodeTraversal.traverse(compiler, scriptParent, new UnwrapGoogLoadModule());


// Record all the scripts first so that the googModuleNamespaces global state can be complete // Record all the scripts first so that the googModuleNamespaces global state can be complete
// before doing any updating also queue up scriptDescriptions for later use in ScriptUpdater // before doing any updating also queue up scriptDescriptions for later use in ScriptUpdater
Expand All @@ -711,8 +711,8 @@ private void processAllFiles(Deque<ScriptDescription> scriptDescriptions, Node s
pushScript(new ScriptDescription()); pushScript(new ScriptDescription());
currentScript.rootNode = c; currentScript.rootNode = c;
scriptDescriptions.addLast(currentScript); scriptDescriptions.addLast(currentScript);
NodeTraversal.traverseEs6(compiler, c, new ScriptPreprocessor()); NodeTraversal.traverse(compiler, c, new ScriptPreprocessor());
NodeTraversal.traverseEs6(compiler, c, new ScriptRecorder()); NodeTraversal.traverse(compiler, c, new ScriptRecorder());
popScript(); popScript();
} }


Expand All @@ -725,28 +725,28 @@ private void processAllFiles(Deque<ScriptDescription> scriptDescriptions, Node s
// scriptDescriptions that were queued up by all the recording. // scriptDescriptions that were queued up by all the recording.
for (Node c = scriptParent.getFirstChild(); c != null; c = c.getNext()) { for (Node c = scriptParent.getFirstChild(); c != null; c = c.getNext()) {
pushScript(scriptDescriptions.removeFirst()); pushScript(scriptDescriptions.removeFirst());
NodeTraversal.traverseEs6(compiler, c, new ScriptUpdater()); NodeTraversal.traverse(compiler, c, new ScriptUpdater());
popScript(); popScript();
} }
} }


@Override @Override
public void hotSwapScript(Node scriptRoot, Node originalRoot) { public void hotSwapScript(Node scriptRoot, Node originalRoot) {
checkState(scriptRoot.isScript(), scriptRoot); checkState(scriptRoot.isScript(), scriptRoot);
NodeTraversal.traverseEs6(compiler, scriptRoot, new UnwrapGoogLoadModule()); NodeTraversal.traverse(compiler, scriptRoot, new UnwrapGoogLoadModule());


rewriteState.removeRoot(originalRoot); rewriteState.removeRoot(originalRoot);


pushScript(new ScriptDescription()); pushScript(new ScriptDescription());
currentScript.rootNode = scriptRoot; currentScript.rootNode = scriptRoot;
NodeTraversal.traverseEs6(compiler, scriptRoot, new ScriptPreprocessor()); NodeTraversal.traverse(compiler, scriptRoot, new ScriptPreprocessor());
NodeTraversal.traverseEs6(compiler, scriptRoot, new ScriptRecorder()); NodeTraversal.traverse(compiler, scriptRoot, new ScriptRecorder());


if (compiler.hasHaltingErrors()) { if (compiler.hasHaltingErrors()) {
return; return;
} }


NodeTraversal.traverseEs6(compiler, scriptRoot, new ScriptUpdater()); NodeTraversal.traverse(compiler, scriptRoot, new ScriptUpdater());
popScript(); popScript();


reportUnrecognizedRequires(); reportUnrecognizedRequires();
Expand Down
Expand Up @@ -99,7 +99,7 @@ public int compare(Var v1, Var v2) {
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
checkNotNull(externs); checkNotNull(externs);
checkNotNull(root); checkNotNull(root);
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
compiler.setLifeCycleStage(LifeCycleStage.RAW); compiler.setLifeCycleStage(LifeCycleStage.RAW);
} }


Expand Down
Expand Up @@ -48,7 +48,7 @@ public CollapseAnonymousFunctions(AbstractCompiler compiler) {


@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
} }


@Override @Override
Expand Down
2 changes: 1 addition & 1 deletion src/com/google/javascript/jscomp/CollapseProperties.java
Expand Up @@ -638,7 +638,7 @@ private void checkForHosedThisReferences(Node function, JSDocInfo docInfo,
(docInfo != null && (docInfo.isConstructorOrInterface() || docInfo.hasThisType())) (docInfo != null && (docInfo.isConstructorOrInterface() || docInfo.hasThisType()))
|| function.isArrowFunction(); || function.isArrowFunction();
if (!isAllowedToReferenceThis) { if (!isAllowedToReferenceThis) {
NodeTraversal.traverseEs6(compiler, function.getLastChild(), NodeTraversal.traverse(compiler, function.getLastChild(),
new NodeTraversal.AbstractShallowCallback() { new NodeTraversal.AbstractShallowCallback() {
@Override @Override
public void visit(NodeTraversal t, Node n, Node parent) { public void visit(NodeTraversal t, Node n, Node parent) {
Expand Down
Expand Up @@ -103,7 +103,7 @@ public void process(Node externs, Node root) {
collapses.clear(); collapses.clear();
nodesToCollapse.clear(); nodesToCollapse.clear();


NodeTraversal.traverseEs6(compiler, root, new GatherCollapses()); NodeTraversal.traverse(compiler, root, new GatherCollapses());


if (!collapses.isEmpty()) { if (!collapses.isEmpty()) {
applyCollapses(); applyCollapses();
Expand Down
2 changes: 1 addition & 1 deletion src/com/google/javascript/jscomp/CollectFunctionNames.java
Expand Up @@ -132,7 +132,7 @@ private static class FunctionRecord implements Serializable {


@Override @Override
public void process(Node externs, Node root) { public void process(Node externs, Node root) {
NodeTraversal.traverseEs6(compiler, root, this); NodeTraversal.traverse(compiler, root, this);
} }


public FunctionNames getFunctionNames() { public FunctionNames getFunctionNames() {
Expand Down

0 comments on commit 4c97e69

Please sign in to comment.