Skip to content

Commit

Permalink
CrossModuleCodeMotion: use CrossModuleReferenceCollector
Browse files Browse the repository at this point in the history
instead of ReferenceCollectingCallback.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=156073685
  • Loading branch information
brad4d authored and Tyler Breisacher committed May 16, 2017
1 parent d66a77c commit 70cbdaa
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/com/google/javascript/jscomp/CrossModuleCodeMotion.java
Expand Up @@ -301,8 +301,8 @@ private void processRead(Reference ref, NamedInfo info) {
} }


private void collectReferences(Node root) { private void collectReferences(Node root) {
ReferenceCollectingCallback collector = new ReferenceCollectingCallback( CrossModuleReferenceCollector collector = new CrossModuleReferenceCollector(
compiler, ReferenceCollectingCallback.DO_NOTHING_BEHAVIOR, compiler, CrossModuleReferenceCollector.DO_NOTHING_BEHAVIOR,
new Es6SyntacticScopeCreator(compiler), new Es6SyntacticScopeCreator(compiler),
new Predicate<Var>() { new Predicate<Var>() {
@Override public boolean apply(Var var) { @Override public boolean apply(Var var) {
Expand All @@ -325,7 +325,7 @@ private void collectReferences(Node root) {
} }


private void processReference( private void processReference(
ReferenceCollectingCallback collector, Reference ref, NamedInfo info, Var v) { CrossModuleReferenceCollector collector, Reference ref, NamedInfo info, Var v) {
Node n = ref.getNode(); Node n = ref.getNode();
if (isRecursiveDeclaration(v, n)) { if (isRecursiveDeclaration(v, n)) {
return; return;
Expand Down Expand Up @@ -387,7 +387,7 @@ private JSModule getModule(Reference ref) {
* where "movable object" is a literal or a function. * where "movable object" is a literal or a function.
*/ */
private boolean maybeProcessDeclaration( private boolean maybeProcessDeclaration(
ReferenceCollectingCallback collector, Reference ref, NamedInfo info) { CrossModuleReferenceCollector collector, Reference ref, NamedInfo info) {
Node name = ref.getNode(); Node name = ref.getNode();
Node parent = name.getParent(); Node parent = name.getParent();
Node grandparent = parent.getParent(); Node grandparent = parent.getParent();
Expand Down Expand Up @@ -453,7 +453,7 @@ private boolean maybeProcessDeclaration(
* Determines whether the given value is eligible to be moved across modules. * Determines whether the given value is eligible to be moved across modules.
*/ */
private static boolean canMoveValue( private static boolean canMoveValue(
ReferenceCollectingCallback collector, Scope scope, Node n) { CrossModuleReferenceCollector collector, Scope scope, Node n) {
// the value is only movable if it's // the value is only movable if it's
// a) nothing, // a) nothing,
// b) a constant literal, // b) a constant literal,
Expand Down

0 comments on commit 70cbdaa

Please sign in to comment.