Split IDE mode setting into a few different settings since it actuall…

…y implies a few different things.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=123039034

src/com/google/javascript/jscomp/AbstractCommandLineRunner.java

@@ -1195,7 +1195,7 @@ int processResults(Result result, List<JSModule> modules, B options) throws IOEx
       outputBundle();
       outputModuleGraphJson();
       return 0;
-    } else if (!options.checksOnly && result.success) {
+    } else if (options.outputJs && result.success) {
       outputModuleGraphJson();
       if (modules == null) {
         outputSingleBinary(options);

src/com/google/javascript/jscomp/AbstractCompiler.java

@@ -264,11 +264,6 @@ LifeCycleStage getLifeCycleStage() {
   /** Passes that do cross-scope modifications use this (eg, InlineVariables) */
   abstract void reportChangeToEnclosingScope(Node n);
 
-  /**
-   * Returns true if compiling in IDE mode.
-   */
-  abstract boolean isIdeMode();
-
   /**
    * Represents the different contexts for which the compiler could have
    * distinct configurations.

src/com/google/javascript/jscomp/CommandLineRunner.java

@@ -1496,6 +1496,7 @@ protected CompilerOptions createOptions() {
     options.setEnvironment(flags.environment);
 
     options.setChecksOnly(flags.checksOnly);
+    options.setOutputJs(!flags.checksOnly);
 
     if (flags.useTypesForOptimization) {
       level.setTypeBasedOptimizationOptions(options);

src/com/google/javascript/jscomp/Compiler.java

@@ -712,8 +712,7 @@ private void compileInternal() {
         return;
       }
 
-      // IDE-mode is defined to stop here, before the heavy rewriting begins.
-      if (!options.checksOnly && !options.ideMode) {
+      if (!options.checksOnly) {
         optimize();
       }
     }
@@ -2112,11 +2111,6 @@ public CodingConvention getCodingConvention() {
     return convention;
   }
 
-  @Override
-  public boolean isIdeMode() {
-    return options.ideMode;
-  }
-
   @Override
   Config getParserConfig(ConfigContext context) {
     if (parserConfig == null) {
@@ -2160,7 +2154,8 @@ Config getParserConfig(ConfigContext context) {
 
   protected Config createConfig(Config.LanguageMode mode) {
     Config config = ParserRunner.createConfig(mode, options.extraAnnotationNames);
-    config.setIdeMode(isIdeMode());
+    config.setPreserveDetailedSourceInfo(options.preservesDetailedSourceInfo());
+    config.setKeepGoing(options.canKeepGoing());
     config.setParseJsDocDocumentation(options.isParseJsDocDocumentation());
     config.setPreserveJsDocWhitespace(options.isPreserveJsDocWhitespace());
     return config;
@@ -2236,7 +2231,7 @@ public int getWarningCount() {
 
   @Override
   boolean hasHaltingErrors() {
-    return !isIdeMode() && getErrorCount() > 0;
+    return !getOptions().canKeepGoing() && getErrorCount() > 0;
   }
 
   /**
@@ -2671,7 +2666,7 @@ public static String getReleaseDate() {
 
   @Override
   void addComments(String filename, List<Comment> comments) {
-    if (!isIdeMode()) {
+    if (!getOptions().preservesDetailedSourceInfo()) {
       throw new UnsupportedOperationException(
           "addComments may only be called in IDE mode.");
     }
@@ -2680,7 +2675,7 @@ void addComments(String filename, List<Comment> comments) {
 
   @Override
   public List<Comment> getComments(String filename) {
-    if (!isIdeMode()) {
+    if (!getOptions().preservesDetailedSourceInfo()) {
       throw new UnsupportedOperationException(
           "getComments may only be called in IDE mode.");
     }

src/com/google/javascript/jscomp/CompilerOptions.java

@@ -105,26 +105,15 @@ public void setInferConst(boolean value) {
    */
   private boolean assumeStrictThis;
 
-  /**
-   * Configures the compiler for use as an IDE backend.  In this mode:
-   * <ul>
-   *  <li>No optimization passes will run.</li>
-   *  <li>The last time custom passes are invoked is
-   *      {@link CustomPassExecutionTime#BEFORE_OPTIMIZATIONS}</li>
-   *  <li>The compiler will always try to process all inputs fully, even
-   *      if it encounters errors.</li>
-   *  <li>The compiler may record more information than is strictly
-   *      needed for codegen.</li>
-   * </ul>
-   */
-  public boolean ideMode;
+  private boolean allowHotswapReplaceScript = false;
+  private boolean preserveDetailedSourceInfo = false;
+  private boolean keepGoing = false;
 
   private boolean parseJsDocDocumentation = false;
   private boolean preserveJsDocWhitespace = false;
 
   /**
-   * Even if checkTypes is disabled, clients might want to still infer types.
-   * This is mostly used when ideMode is enabled.
+   * Even if checkTypes is disabled, clients such as IDEs might want to still infer types.
    */
   boolean inferTypes;
 
@@ -730,6 +719,8 @@ public void setAppNameStr(String appNameStr) {
 
   public boolean checksOnly;
 
+  public boolean outputJs;
+
   public boolean generateExports;
 
   // TODO(dimvar): generate-exports should always run after typechecking.
@@ -1094,6 +1085,7 @@ public CompilerOptions() {
     appNameStr = "";
     recordFunctionInformation = false;
     checksOnly = false;
+    outputJs = true;
     generateExports = false;
     generateExportsAfterTypeChecking = true;
     exportLocalPropertyDefinitions = false;
@@ -1513,6 +1505,10 @@ public void setChecksOnly(boolean checksOnly) {
     this.checksOnly = checksOnly;
   }
 
+  public void setOutputJs(boolean outputJs) {
+    this.outputJs = outputJs;
+  }
+
   public void setGenerateExports(boolean generateExports) {
     this.generateExports = generateExports;
   }
@@ -1808,8 +1804,54 @@ public void setPropertyInvalidationErrors(
          ImmutableMap.copyOf(propertyInvalidationErrors);
   }
 
+  /**
+   * Configures the compiler for use as an IDE backend.  In this mode:
+   * <ul>
+   *  <li>No optimization passes will run.</li>
+   *  <li>The last time custom passes are invoked is
+   *      {@link CustomPassExecutionTime#BEFORE_OPTIMIZATIONS}</li>
+   *  <li>The compiler will always try to process all inputs fully, even
+   *      if it encounters errors.</li>
+   *  <li>The compiler may record more information than is strictly
+   *      needed for codegen.</li>
+   * </ul>
+   *
+   * @deprecated Some "IDE" clients will need some of these options but not
+   * others. Consider calling setChecksOnly, setAllowRecompilation, etc,
+   * explicitly, instead of calling this method which does a variety of
+   * different things.
+   */
+  @Deprecated
   public void setIdeMode(boolean ideMode) {
-    this.ideMode = ideMode;
+    setChecksOnly(ideMode);
+    setKeepGoing(ideMode);
+    setAllowHotswapReplaceScript(ideMode);
+    setPreserveDetailedSourceInfo(ideMode);
+    setParseJsDocDocumentation(ideMode);
+  }
+
+  void setAllowHotswapReplaceScript(boolean allowRecompilation) {
+    this.allowHotswapReplaceScript = allowRecompilation;
+  }
+
+  boolean allowsHotswapReplaceScript() {
+    return allowHotswapReplaceScript;
+  }
+
+  public void setPreserveDetailedSourceInfo(boolean preserveDetailedSourceInfo) {
+    this.preserveDetailedSourceInfo = preserveDetailedSourceInfo;
+  }
+
+  boolean preservesDetailedSourceInfo() {
+    return preserveDetailedSourceInfo;
+  }
+
+  void setKeepGoing(boolean keepGoing) {
+    this.keepGoing = keepGoing;
+  }
+
+  boolean canKeepGoing() {
+    return keepGoing;
   }
 
   /**
@@ -1829,7 +1871,7 @@ public void setParseJsDocDocumentation(boolean parseJsDocDocumentation) {
    * @return True when JSDoc documentation will be parsed, false if not.
    */
   public boolean isParseJsDocDocumentation() {
-    return this.ideMode || this.parseJsDocDocumentation;
+    return this.parseJsDocDocumentation;
   }
 
   /**

src/com/google/javascript/jscomp/ControlFlowAnalysis.java

@@ -588,7 +588,7 @@ private void handleBreak(Node node) {
         lastJump = cur;
       }
       if (parent == null) {
-        if (compiler.isIdeMode()) {
+        if (compiler.getOptions().canKeepGoing()) {
           // In IDE mode, we expect that the data flow graph may
           // not be well-formed.
           return;

src/com/google/javascript/jscomp/DefaultPassConfig.java

@@ -156,7 +156,7 @@ public DefaultPassConfig(CompilerOptions options) {
     // wrap them in a function call that is stripped later, this shouldn't
     // be done in IDE mode where AST changes may be unexpected.
     protectHiddenSideEffects = options != null &&
-        options.protectHiddenSideEffects && !options.ideMode;
+        options.protectHiddenSideEffects && !options.allowsHotswapReplaceScript();
   }
 
   @Override
@@ -178,7 +178,7 @@ PreprocessorSymbolTable getPreprocessorSymbolTable() {
   }
 
   void maybeInitializePreprocessorSymbolTable(AbstractCompiler compiler) {
-    if (options.ideMode) {
+    if (options.preservesDetailedSourceInfo()) {
       Node root = compiler.getRoot();
       if (preprocessorSymbolTable == null ||
           preprocessorSymbolTable.getRootNode() != root) {
@@ -188,7 +188,7 @@ void maybeInitializePreprocessorSymbolTable(AbstractCompiler compiler) {
   }
 
   void maybeInitializeModuleRewriteState() {
-    if (options.ideMode && this.moduleRewriteState == null) {
+    if (options.allowsHotswapReplaceScript() && this.moduleRewriteState == null) {
       this.moduleRewriteState = new ClosureRewriteModule.GlobalRewriteState();
     }
   }
@@ -370,7 +370,7 @@ protected List<PassFactory> getChecks() {
 
       // We assume that only IDE-mode clients will try to query the
       // typed scope creator after the compile job.
-      if (!options.ideMode) {
+      if (!options.preservesDetailedSourceInfo()) {
         checks.add(clearTypedScopePass);
       }
     }

src/com/google/javascript/jscomp/JsAst.java

@@ -150,7 +150,7 @@ private void parse(AbstractCompiler compiler) {
       root = result.ast;
       features = result.features;
 
-      if (compiler.isIdeMode()) {
+      if (compiler.getOptions().preservesDetailedSourceInfo()) {
         compiler.addComments(sourceFile.getName(), result.comments);
       }
     } catch (IOException e) {
@@ -165,7 +165,8 @@ private void parse(AbstractCompiler compiler) {
         // Note: we use the ErrorManager here rather than the ErrorReporter as
         // we don't want to fail if the error was excluded by a warning guard, conversely
         // we do want to fail if a warning was promoted to an error.
-        || (errorManager.getErrorCount() > startErrorCount && !compiler.isIdeMode())) {
+        || (errorManager.getErrorCount() > startErrorCount
+            && !compiler.getOptions().canKeepGoing())) {
       // There was a parse error or IOException, so use a dummy block.
 
 

src/com/google/javascript/jscomp/Linter.java

@@ -62,7 +62,11 @@ private static void lint(Path path, boolean fix) throws IOException {
     // in LintPassConfig can all handle untranspiled ES6.
     options.setSkipTranspilationAndCrash(true);
 
-    options.setIdeMode(true);
+    options.setPreserveDetailedSourceInfo(true);
+
+    // TODO(tbreisacher): Remove this so that people don't miss parse errors.
+    options.setKeepGoing(true);
+
     options.setCodingConvention(new GoogleCodingConvention());
 
     // Even though we're not running the typechecker, enable the checkTypes DiagnosticGroup, since

src/com/google/javascript/jscomp/parsing/Config.java

@@ -50,9 +50,14 @@ public enum LanguageMode {
   boolean preserveJsDocWhitespace;
 
   /**
-   * Whether we're in IDE mode.
+   * Whether to keep detailed source location information such as the exact length of every node.
    */
-  boolean isIdeMode;
+  boolean preserveDetailedSourceInfo;
+
+  /**
+   * Whether to keep going after encountering a parse error.
+   */
+  boolean keepGoing;
 
   /**
    * Recognized JSDoc annotations, mapped from their name to their internal
@@ -96,8 +101,12 @@ private static Map<String, Annotation> buildAnnotationNames(
     return annotationBuilder.build();
   }
 
-  public void setIdeMode(boolean isIdeMode) {
-    this.isIdeMode = isIdeMode;
+  public void setPreserveDetailedSourceInfo(boolean preserveDetailedSourceInfo) {
+    this.preserveDetailedSourceInfo = preserveDetailedSourceInfo;
+  }
+
+  public void setKeepGoing(boolean keepGoing) {
+    this.keepGoing = keepGoing;
   }
 
   public void setParseJsDocDocumentation(boolean parseJsDocDocumentation) {

src/com/google/javascript/jscomp/parsing/IRFactory.java

@@ -931,13 +931,13 @@ private JSDocInfo parseInlineTypeDoc(Comment node) {
   // Set the length on the node if we're in IDE mode.
   void maybeSetLength(
       Node node, SourcePosition start, SourcePosition end) {
-    if (config.isIdeMode) {
+    if (config.preserveDetailedSourceInfo) {
       node.setLength(end.offset - start.offset);
     }
   }
 
   void maybeSetLengthFrom(Node node, Node ref) {
-    if (config.isIdeMode) {
+    if (config.preserveDetailedSourceInfo) {
       node.setLength(ref.getLength());
     }
   }
@@ -1253,9 +1253,9 @@ Node processFunction(FunctionDeclarationTree functionTree) {
 
       Node bodyNode = transform(functionTree.functionBody);
       if (!isArrow && !isSignature && !bodyNode.isBlock()) {
-        // When in ideMode the parser tries to parse some constructs the
+        // When in "keep going" mode the parser tries to parse some constructs the
         // compiler doesn't support, repair it here.
-        Preconditions.checkState(config.isIdeMode);
+        Preconditions.checkState(config.keepGoing);
         bodyNode = IR.block();
       }
       parseDirectives(bodyNode);

src/com/google/javascript/jscomp/parsing/ParserRunner.java

@@ -92,7 +92,7 @@ public static ParseResult parse(
     // TODO(johnlenz): unify "SourceFile", "Es6ErrorReporter" and "Config"
     SourceFile file = new SourceFile(sourceFile.getName(), sourceString);
     Es6ErrorReporter es6ErrorReporter =
-        new Es6ErrorReporter(errorReporter, config.isIdeMode);
+        new Es6ErrorReporter(errorReporter, config.keepGoing);
     com.google.javascript.jscomp.parsing.parser.Parser.Config es6config =
         new com.google.javascript.jscomp.parsing.parser.Parser.Config(mode(
             config.languageMode));
@@ -101,15 +101,15 @@ public static ParseResult parse(
     Node root = null;
     List<Comment> comments = ImmutableList.of();
     FeatureSet features = p.getFeatures();
-    if (tree != null && (!es6ErrorReporter.hadError() || config.isIdeMode)) {
+    if (tree != null && (!es6ErrorReporter.hadError() || config.preserveDetailedSourceInfo)) {
       IRFactory factory =
           IRFactory.transformTree(tree, sourceFile, sourceString, config, errorReporter);
       root = factory.getResultNode();
       features = features.require(factory.getFeatures());
       root.setIsSyntheticBlock(true);
       root.putProp(Node.FEATURE_SET, features);
 
-      if (config.isIdeMode) {
+      if (config.preserveDetailedSourceInfo) {
         comments = p.getComments();
       }
     }

src/com/google/javascript/jscomp/parsing/TypeTransformationParser.java

@@ -250,7 +250,6 @@ private boolean checkParameterCount(Node expr, Keywords keyword) {
   public boolean parseTypeTransformation() {
     Config config =
         new Config(new HashSet<String>(), new HashSet<String>(), LanguageMode.ECMASCRIPT6);
-    config.setIdeMode(true);
     // TODO(lpino): ParserRunner reports errors if the expression is not
     // ES6 valid. We need to abort the validation of the type transformation
     // whenever an error is reported.

test/com/google/debugging/sourcemap/SourceMapTestCase.java

@@ -283,8 +283,7 @@ protected RunResult compile(
     Compiler compiler = new Compiler();
     CompilerOptions options = getCompilerOptions();
 
-    // Turn on IDE mode to get rid of optimizations.
-    options.ideMode = true;
+    options.setChecksOnly(true);
 
     List<SourceFile> inputs =
         ImmutableList.of(SourceFile.fromCode(fileName1, js1));