Skip to content

Commit

Permalink
Prefer Multimap interface types over implementation types.
Browse files Browse the repository at this point in the history
This change is required before the migration to MultimapBuilder can be
completed.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=141496601
  • Loading branch information
kluever authored and blickly committed Dec 9, 2016
1 parent c5f1c9c commit 9315740
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/com/google/javascript/jscomp/RenameVars.java
Expand Up @@ -21,10 +21,10 @@
import com.google.common.base.Preconditions; import com.google.common.base.Preconditions;
import com.google.common.collect.ArrayListMultimap; import com.google.common.collect.ArrayListMultimap;
import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ListMultimap;
import com.google.javascript.jscomp.NodeTraversal.AbstractPostOrderCallback; import com.google.javascript.jscomp.NodeTraversal.AbstractPostOrderCallback;
import com.google.javascript.jscomp.NodeTraversal.ScopedCallback; import com.google.javascript.jscomp.NodeTraversal.ScopedCallback;
import com.google.javascript.rhino.Node; import com.google.javascript.rhino.Node;

import java.util.ArrayList; import java.util.ArrayList;
import java.util.Comparator; import java.util.Comparator;
import java.util.HashMap; import java.util.HashMap;
Expand All @@ -34,7 +34,6 @@
import java.util.Set; import java.util.Set;
import java.util.SortedSet; import java.util.SortedSet;
import java.util.TreeSet; import java.util.TreeSet;

import javax.annotation.Nullable; import javax.annotation.Nullable;


/** /**
Expand Down Expand Up @@ -88,7 +87,7 @@ final class RenameVars implements CompilerPass {
// Logic for bleeding functions, where the name leaks into the outer // Logic for bleeding functions, where the name leaks into the outer
// scope on IE but not on other browsers. // scope on IE but not on other browsers.
private final Set<Var> localBleedingFunctions = new HashSet<>(); private final Set<Var> localBleedingFunctions = new HashSet<>();
private final ArrayListMultimap<Scope, Var> localBleedingFunctionsPerScope = private final ListMultimap<Scope, Var> localBleedingFunctionsPerScope =
ArrayListMultimap.create(); ArrayListMultimap.create();


class Assignment { class Assignment {
Expand Down

0 comments on commit 9315740

Please sign in to comment.