Produce an "internal compiler error" for Errors (such as StackOverFlo…

…wError), not just Exceptions

This makes it much easier to debug when a StackOverflowError happens

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=163140994

src/com/google/javascript/jscomp/AbstractCompiler.java

@@ -184,7 +184,7 @@ static enum MostRecentTypechecker {
   /**
    * Report an internal error.
    */
-  abstract void throwInternalError(String msg, Exception cause);
+  abstract void throwInternalError(String msg, Throwable cause);
 
   /**
    * Gets the current coding convention.
@@ -590,13 +590,13 @@ abstract void updateGlobalVarReferences(Map<Var, ReferenceCollection>
 
    /**
     * Stores a map of default @define values.  These values
-    * can be overriden by values specifically set in the CompilerOptions.
+    * can be overridden by values specifically set in the CompilerOptions.
     */
    abstract void setDefaultDefineValues(ImmutableMap<String, Node> values);
 
    /**
     * Gets a map of default @define values.  These values
-    * can be overriden by values specifically set in the CompilerOptions.
+    * can be overridden by values specifically set in the CompilerOptions.
     */
    abstract ImmutableMap<String, Node> getDefaultDefineValues();
 

src/com/google/javascript/jscomp/Compiler.java

@@ -2799,7 +2799,7 @@ public CheckLevel getErrorLevel(JSError error) {
    * Report an internal error.
    */
   @Override
-  void throwInternalError(String message, Exception cause) {
+  void throwInternalError(String message, Throwable cause) {
     String finalMessage = "INTERNAL COMPILER ERROR.\nPlease report this problem.\n\n" + message;
 
     RuntimeException e = new RuntimeException(finalMessage, cause);

src/com/google/javascript/jscomp/NodeTraversal.java

@@ -271,7 +271,7 @@ public NodeTraversal(AbstractCompiler compiler, Callback cb,
     this.useBlockScope = scopeCreator.hasBlockScope();
   }
 
-  private void throwUnexpectedException(Exception unexpectedException) {
+  private void throwUnexpectedException(Throwable unexpectedException) {
     // If there's an unexpected exception, try to get the
     // line number of the code that caused it.
     String message = unexpectedException.getMessage();
@@ -307,7 +307,7 @@ public void traverse(Node root) {
       // null parent ensures that the shallow callbacks will traverse root
       traverseBranch(root, null);
       popScope();
-    } catch (Exception unexpectedException) {
+    } catch (Error | Exception unexpectedException) {
       throwUnexpectedException(unexpectedException);
     }
   }
@@ -326,7 +326,7 @@ void traverseRoots(Node externs, Node root) {
       traverseBranch(root, scopeRoot);
 
       popScope();
-    } catch (Exception unexpectedException) {
+    } catch (Error | Exception unexpectedException) {
       throwUnexpectedException(unexpectedException);
     }
   }
@@ -362,7 +362,7 @@ void traverseWithScope(Node root, Scope s) {
       pushScope(s);
       traverseBranch(root, null);
       popScope();
-    } catch (Exception unexpectedException) {
+    } catch (Error | Exception unexpectedException) {
       throwUnexpectedException(unexpectedException);
     }
   }
@@ -437,7 +437,7 @@ private void traverseScopeRoot(Node scopeRoot) {
       initScopeRoots(scopeRoot.getParent());
       // null parent ensures that the shallow callbacks will traverse root
       traverseBranch(scopeRoot, scopeRoot.getParent());
-    } catch (Exception unexpectedException) {
+    } catch (Error | Exception unexpectedException) {
       throwUnexpectedException(unexpectedException);
     }
   }