Add linter warning and suggested fix for extra (i.e. unused) goog.req…

…uireType statements. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=229796822
google · Jan 18, 2019 · a28ed37 · a28ed37
1 parent f77d7c1
commit a28ed37
Show file tree

Hide file tree

Showing 3 changed files with 281 additions and 94 deletions.
diff --git a/src/com/google/javascript/jscomp/CheckMissingAndExtraRequires.java b/src/com/google/javascript/jscomp/CheckMissingAndExtraRequires.java
@@ -154,19 +154,24 @@ private static ImmutableList<String> getClassNames(String qualifiedName) {
   }
 
   // TODO(tbreisacher): Update CodingConvention.extractClassNameIf{Require,Provide} to match this.
-  private String extractNamespace(Node call, String functionName) {
+  private String extractNamespace(Node call, String... primitiveNames) {
     Node callee = call.getFirstChild();
-    if (callee.isGetProp() && callee.matchesQualifiedName(functionName)) {
+    if (!callee.isGetProp()) {
-      Node target = callee.getNext();
+      return null;
-      if (target != null && target.isString()) {
+    }
-        return target.getString();
+    for (String primitiveName : primitiveNames) {
+      if (callee.matchesQualifiedName(primitiveName)) {
+        Node target = callee.getNext();
+        if (target != null && target.isString()) {
+          return target.getString();
+        }
       }
     }
     return null;
   }
 
   private String extractNamespaceIfRequire(Node call) {
-    return extractNamespace(call, "goog.require");
+    return extractNamespace(call, "goog.require", "goog.requireType");
   }
 
   private String extractNamespaceIfForwardDeclare(Node call) {