Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Tighten the dead property elimination deoptimzation
The previous implemention was a little too restrictive for most environments. We now only trigger a deop if any of the following is true: a. A Object.defineProperty(...) where an aliased property name is being assigned to an aliased descriptor or the descriptor contains a getter/setter def. b. A Object.defineProperties where the last param is not an object literal. To ensure safety, a property being defined with an aliased descriptor now just blacklists that property name. Finally, a new diagnostic error is introduced to report when there is a pattern that triggers a critical deoptimization. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=124891113
- Loading branch information
1 parent
d07eed8
commit a593a49
Showing
2 changed files
with
136 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters