Disable InlineVariables when language_out is ES6+, for now.

Add test case showing that InlineVariables sometimes produces incorrect code when operating on ES6 features. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=169600823
google · Sep 22, 2017 · a5b81ba · a5b81ba
1 parent 36f8393
commit a5b81ba
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 5 deletions.
diff --git a/src/com/google/javascript/jscomp/DefaultPassConfig.java b/src/com/google/javascript/jscomp/DefaultPassConfig.java
@@ -1704,7 +1704,7 @@ protected CompilerPass create(AbstractCompiler compiler) {
 
     @Override
     protected FeatureSet featureSet() {
-      return ES8;
+      return ES5;
     }
   };
 
@@ -2523,7 +2523,7 @@ protected CompilerPass create(AbstractCompiler compiler) {
 
         @Override
         protected FeatureSet featureSet() {
-          return ES8_MODULES;
+          return ES5;
         }
       };
 
@@ -2537,7 +2537,7 @@ protected CompilerPass create(AbstractCompiler compiler) {
 
         @Override
         protected FeatureSet featureSet() {
-          return ES8_MODULES;
+          return ES5;
         }
       };
 

diff --git a/test/com/google/javascript/jscomp/InlineVariablesTest.java b/test/com/google/javascript/jscomp/InlineVariablesTest.java
@@ -54,6 +54,30 @@ public void tearDown() {
     inlineLocalsOnly = false;
   }
 
+  // TODO(tbreisacher): Fix this and re-enable InlineVariables in ES6-out mode.
+  public void testPassProducesInvalidCode() {
+    test(
+        LINE_JOINER.join(
+            "function f(x = void 0) {",
+            "  var z;",
+            "  {",
+            "    const y = {};",
+            "    x && (y['x'] = x);",
+            "    z = y;",
+            "  }",
+            "  return z;",
+            "}"),
+        LINE_JOINER.join(
+            "function f(x = void 0) {",
+            "  {",
+            "    const y = {};",
+            "    x && (y['x'] = x);",
+            "  }",
+            "  // NOTE! Invalid code: y is no longer in scope here.",
+            "  return y;",
+            "}"));
+  }
+
   // Test respect for scopes and blocks
 
   public void testInlineGlobal() {

diff --git a/test/com/google/javascript/jscomp/IntegrationTest.java b/test/com/google/javascript/jscomp/IntegrationTest.java
@@ -4569,7 +4569,8 @@ public void testDefaultParameters() {
         "var a={a:9}; a=void 0===a?{a:5}:a;alert(3+a.a)");
   }
 
-  public void testDefaultParametersNonTranspiling() {
+  // TODO(tbreisacher): Enable this test when InlineVariables is re-enabled in non-transpile mode.
+  public void disabled_testDefaultParametersNonTranspiling() {
     CompilerOptions options = createCompilerOptions();
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
     options.setLanguageIn(LanguageMode.ECMASCRIPT_2017);
@@ -4606,7 +4607,8 @@ public void testRestObjectPatternParameters() {
             "}(1,1,1,1,1))"));
   }
 
-  public void testRestObjectPatternParametersNonTranspiling() {
+  // TODO(tbreisacher): Enable this test when InlineVariables is re-enabled in non-transpile mode.
+  public void disabled_testRestObjectPatternParametersNonTranspiling() {
     CompilerOptions options = createCompilerOptions();
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
     options.setLanguageIn(LanguageMode.ECMASCRIPT_2017);