Allow --print_file_after_each_pass to take multiple filenames. This i…

…s helpful in debugging CollapseProperties bugs where it appears a name is collapsed in one file but not in another. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=133853621
google · Sep 21, 2016 · c69d49f · c69d49f
1 parent 8549da7
commit c69d49f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/src/com/google/javascript/jscomp/Compiler.java b/src/com/google/javascript/jscomp/Compiler.java
@@ -987,12 +987,19 @@ final void afterPass(String passName) {
   }
 
   final String getCurrentJsSource() {
-    String filename = options.fileToPrintAfterEachPass;
+    List<String> filenames = options.filesToPrintAfterEachPass;
-    if (filename == null) {
+    if (filenames.isEmpty()) {
       return toSource();
     } else {
-      Node script = getScriptNode(filename);
+      StringBuilder builder = new StringBuilder();
-      return script != null ? toSource(script) : ("File '" + filename + "' not found");
+      for (String filename : filenames) {
+        Node script = getScriptNode(filename);
+        String source = script != null
+            ? "// " + script.getSourceFileName() + "\n" + toSource(script)
+            : "File '" + filename + "' not found";
+        builder.append(source);
+      }
+      return builder.toString();
     }
   }
 

diff --git a/src/com/google/javascript/jscomp/CompilerOptions.java b/src/com/google/javascript/jscomp/CompilerOptions.java
@@ -880,15 +880,16 @@ public void setTrustedStrings(boolean yes) {
 
   // Should only be used when debugging compiler bugs.
   boolean printSourceAfterEachPass;
-  // Used to narrow down the printed source when overall input size is large.
+  // Used to narrow down the printed source when overall input size is large. If this is empty,
-  String fileToPrintAfterEachPass;
+  // the entire source is printed.
+  List<String> filesToPrintAfterEachPass = ImmutableList.of();
 
   public void setPrintSourceAfterEachPass(boolean printSource) {
     this.printSourceAfterEachPass = printSource;
   }
 
-  public void setFileToPrintAfterEachPass(String filename) {
+  public void setFilesToPrintAfterEachPass(List<String> filenames) {
-    this.fileToPrintAfterEachPass = filename;
+    this.filesToPrintAfterEachPass = filenames;
   }
 
   String reportPath;