Rename completeCompilation and make it run after serialization.

------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=157532917
google · May 31, 2017 · e19dfa6 · e19dfa6
1 parent 99f5e46
commit e19dfa6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/com/google/javascript/jscomp/AbstractCommandLineRunner.java b/src/com/google/javascript/jscomp/AbstractCommandLineRunner.java
@@ -1158,8 +1158,8 @@ private Result performStage1andSave(String filename) {
       compiler.parseForCompilation();
       if (!compiler.hasErrors()) {
         compiler.stage1Passes();
-        compiler.completeCompilation();
         compiler.saveState(serializedOutputStream);
+        compiler.performPostCompilationTasks();
       }
     } catch (IOException e) {
       compiler.report(JSError.make(COULD_NOT_SERIALIZE_AST, filename));
@@ -1179,7 +1179,7 @@ private Result restoreAndPerformStage2(String filename) {
       if (!compiler.hasErrors()) {
           compiler.stage2Passes();
       }
-      compiler.completeCompilation();
+      compiler.performPostCompilationTasks();
     } catch (IOException e) {
       compiler.report(JSError.make(COULD_NOT_DESERIALIZE_AST, filename));
     } finally {
@@ -1200,7 +1200,7 @@ private Result performFullCompilation() {
         if (!compiler.hasErrors()) {
           compiler.stage2Passes();
         }
-        compiler.completeCompilation();
+        compiler.performPostCompilationTasks();
       }
     } finally {
       // Make sure we generate a report of errors and warnings even if the compiler throws an

diff --git a/src/com/google/javascript/jscomp/Compiler.java b/src/com/google/javascript/jscomp/Compiler.java
@@ -746,7 +746,7 @@ public <T1 extends SourceFile, T2 extends SourceFile> Result compile(
             stage2Passes();
           }
         }
-        completeCompilation();
+        performPostCompilationTasks();
       }
     } finally {
       generateReport();
@@ -801,7 +801,7 @@ public <T extends SourceFile> Result compileModules(
             stage2Passes();
           }
         }
-        completeCompilation();
+        performPostCompilationTasks();
       }
     } finally {
       generateReport();
@@ -905,12 +905,12 @@ private void performChecksAndTranspilation() {
    * <p> DON'T call it if the compiler threw an exception.
    * <p> DO call it even when {@code hasErrors()} returns true.
    */
-  public void completeCompilation() {
+  public void performPostCompilationTasks() {
     runInCompilerThread(new Callable<Void>() {
 
       @Override
       public Void call() throws Exception {
-        completeCompilationInternal();
+        performPostCompilationTasksInternal();
         return null;
       }
 
@@ -920,7 +920,7 @@ public Void call() throws Exception {
   /**
    * Performs all the bookkeeping required at the end of a compilation.
    */
-  private void completeCompilationInternal() {
+  private void performPostCompilationTasksInternal() {
     if (options.recordFunctionInformation) {
       recordFunctionInformation();
     }