Rename keepGoing option to continueAfterErrors which is more descriptive

------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=123262002
google · May 25, 2016 · f4a119b · f4a119b
1 parent a2c143e
commit f4a119b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/src/com/google/javascript/jscomp/Compiler.java b/src/com/google/javascript/jscomp/Compiler.java
@@ -2155,7 +2155,7 @@ Config getParserConfig(ConfigContext context) {
   protected Config createConfig(Config.LanguageMode mode) {
     Config config = ParserRunner.createConfig(mode, options.extraAnnotationNames);
     config.setPreserveDetailedSourceInfo(options.preservesDetailedSourceInfo());
-    config.setKeepGoing(options.canKeepGoing());
+    config.setKeepGoing(options.canContinueAfterErrors());
     config.setParseJsDocDocumentation(options.isParseJsDocDocumentation());
     config.setPreserveJsDocWhitespace(options.isPreserveJsDocWhitespace());
     return config;
@@ -2231,14 +2231,14 @@ public int getWarningCount() {
 
   @Override
   boolean hasHaltingErrors() {
-    return !getOptions().canKeepGoing() && getErrorCount() > 0;
+    return !getOptions().canContinueAfterErrors() && getErrorCount() > 0;
   }
 
   /**
    * Consults the {@link ErrorManager} to see if we've encountered errors
    * that should halt compilation. <p>
    *
-   * If {@link CompilerOptions#ideMode} is {@code true}, this function
+   * If {@link CompilerOptions#canContinueAfterErrors} is {@code true}, this function
    * always returns {@code false} without consulting the error manager. The
    * error manager will continue to be told about new errors and warnings, but
    * the compiler will complete compilation of all inputs.<p>

diff --git a/src/com/google/javascript/jscomp/CompilerOptions.java b/src/com/google/javascript/jscomp/CompilerOptions.java
@@ -107,7 +107,7 @@ public void setInferConst(boolean value) {
 
   private boolean allowHotswapReplaceScript = false;
   private boolean preserveDetailedSourceInfo = false;
-  private boolean keepGoing = false;
+  private boolean continueAfterErrors = false;
 
   private boolean parseJsDocDocumentation = false;
   private boolean preserveJsDocWhitespace = false;
@@ -1832,7 +1832,7 @@ public void setPropertyInvalidationErrors(
   @Deprecated
   public void setIdeMode(boolean ideMode) {
     setChecksOnly(ideMode);
-    setKeepGoing(ideMode);
+    setContinueAfterErrors(ideMode);
     setAllowHotswapReplaceScript(ideMode);
     setPreserveDetailedSourceInfo(ideMode);
     setParseJsDocDocumentation(ideMode);
@@ -1854,12 +1854,12 @@ boolean preservesDetailedSourceInfo() {
     return preserveDetailedSourceInfo;
   }
 
-  public void setKeepGoing(boolean keepGoing) {
+  public void setContinueAfterErrors(boolean continueAfterErrors) {
-    this.keepGoing = keepGoing;
+    this.continueAfterErrors = continueAfterErrors;
   }
 
-  boolean canKeepGoing() {
+  boolean canContinueAfterErrors() {
-    return keepGoing;
+    return continueAfterErrors;
   }
 
   /**

diff --git a/src/com/google/javascript/jscomp/ControlFlowAnalysis.java b/src/com/google/javascript/jscomp/ControlFlowAnalysis.java
@@ -588,7 +588,7 @@ private void handleBreak(Node node) {
         lastJump = cur;
       }
       if (parent == null) {
-        if (compiler.getOptions().canKeepGoing()) {
+        if (compiler.getOptions().canContinueAfterErrors()) {
           // In IDE mode, we expect that the data flow graph may
           // not be well-formed.
           return;

diff --git a/src/com/google/javascript/jscomp/JsAst.java b/src/com/google/javascript/jscomp/JsAst.java
@@ -166,7 +166,7 @@ private void parse(AbstractCompiler compiler) {
         // we don't want to fail if the error was excluded by a warning guard, conversely
         // we do want to fail if a warning was promoted to an error.
         || (errorManager.getErrorCount() > startErrorCount
-            && !compiler.getOptions().canKeepGoing())) {
+            && !compiler.getOptions().canContinueAfterErrors())) {
       // There was a parse error or IOException, so use a dummy block.