Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle more special characters in file paths which cause createUri to throw exceptions #1818

Closed
wants to merge 1 commit into from
Closed

Handle more special characters in file paths which cause createUri to throw exceptions #1818

wants to merge 1 commit into from

Conversation

ChadKillingsworth
Copy link
Collaborator

@ChadKillingsworth ChadKillingsworth commented May 26, 2016 •
edited by Dominator008

Fixes #1817

This change is Reviewable

@dimvar
Copy link
Contributor

dimvar commented May 26, 2016

LGTM. I'll bring this in today or tomorrow.

@dimvar dimvar self-assigned this May 26, 2016
@blickly blickly closed this in 747aa4d May 26, 2016
@Dominator008 Dominator008 mentioned this pull request May 27, 2016
Closed
@blickly
Copy link
Contributor

blickly commented Jun 22, 2017

Looks like this still fails (with an error rather than a crash) if the file contains an export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dimvar dimvar

Labels
cla: yes Import In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ChadKillingsworth @dimvar @blickly @Dominator008 @googlebot