Fix charset in inline data url sourcemaps #2856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatrixFrog
reviewed
Mar 20, 2018
| if (md.equals(metadata)) { | ||
| byte[] data = BaseEncoding.base64().decode( | ||
| url.substring(base64StartIndex + BASE64_START.length())); | ||
| return new String(data, StandardCharsets.UTF_8); |
There was a problem hiding this comment.
nit: Let's static-import UTF_8 and remove StandardCharsets. here.
MatrixFrog
reviewed
Mar 20, 2018
| * Based on https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URIs | ||
| * @param url | ||
| * @return String or null. | ||
| */ |
There was a problem hiding this comment.
add @Nullable annotation since we explicitly expect this to return null in some cases.
|
otherwise lgtm |
|
done |
|
Can you squash this into a single commit as well? (We have a bug open to fix our script so it can accept multi-commit PRs but I don't expect we'll actually fix it anytime soon, if I'm being honest) |
|
done.
classic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that babel produces inline source maps of the form:
//# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJ2ZXJzaW9uIjozLCJzb3VyY2VzIjpbImZyb250ZW5kL2FwcC9yZWFjdC1jb21wb25lbnRzL2FwcC5qc3giXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUE7Ozs7QUFJQSxTQUFTLE9BQVQsUUFBd0IsWUFBeEI7QUFDQSxPQUFPLEdBQVAsTUFBZ0IsVUFBaEI7QUFDQSxPQUFPLFlBQVAsTUFBeUIsbUJBQXpCO0FBQ0EsU0FBUyxTQUFULFFBQTBCLGFBQTFCO0FBQ0EsT0FBTyxNQUFQLE1BQW1CLFdBQW5COztBQUVBO0FBQ0EsTUFBTSxlQUFOLFNBQThCLE1BQU0sU0FBcEMsQ0FBOEM7QUFDMUM7QUFDQSxnQkFBWSxLQUFaLEVBQW1CLE9BQW5CLEVBQTRCO0FBQ3hCLGNBQU0sS0FBTixFQUFhLE9BQWI7QUFDQSxhQUFLLEtBQUwsR0FBYTtBQUNULDJCQUFlLGVBRE4sRUFDdUI7QUFDaEMsNkJBQWlCO0FBQ2IsMEJBQVU7QUFERyxhQUZSO0FBS1QsMkJBQWU7QUFDWCwwQkFBVTtBQURDLGFBTE47QUFRVCw0Q0FBaUMsSUFBSSxJQUFKLEVBQUQsQ0FBVyxPQUFYLEVBUnZCLENBUTZDO0FBUj......This is not recognized by the SourceMapResolver because of the 'charset=utf-8'
See acceptable data url format: https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URIs