Cleanup nullability annotations #3334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
realityforge
commented
Apr 15, 2019
•
realityforge
commented
- Remove ! if type is nonnull by default
|
Created internal issue http://b/130555289 |
lauraharker
added
the
internal-issue-created
|
Google's style guide mandates that all non-primitive or literal type references must have an explicit I'd be happy to see a few of the changes in this PR land, like @realityforge could you revert the changes to non-primitive or literal types? |
… type is nonnull by default
realityforge
force-pushed
the
CleanupNullabilityAnnotations
branch
from
9482dc0
to
c4ebb14
Compare
|
@lauraharker I believe it is good to go. Holler if there is something more that needs to be done. |
lauraharker
requested changes
Apr 16, 2019
realityforge
force-pushed
the
CleanupNullabilityAnnotations
branch
from
c4ebb14
to
79f441b
Compare
|
@lauraharker Alright ... next attempt ;) |
|
Looks good to me. Importing for internal review. |
lauraharker
approved these changes
Apr 16, 2019
jDramaix
pushed a commit
to google/elemental2
that referenced
this pull request
Apr 29, 2019
- Remove ! when the primitive type is nonnull by default - Move nullability-marker "?" to the beginning of the type Closes google/closure-compiler#3334. PiperOrigin-RevId: 245823520
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.