Improve globbing algorithm. Fixes #439 #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add tests for this? |
|
i'm open to suggestions. any test that interacts with the file system tends to be non-portable, because it would break as soon as you run it on a different build system (e.g., inside google) |
|
OK, lets go with this. |
concavelenz
added a commit
that referenced
this pull request
Jun 5, 2014
Improve globbing algorithm. Fixes #439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bugs in the globbing algorithm so that relative paths ("../foo/**.js") work better. Also, if you choose a directory, we automatically glob all the js files in that directory.