[ASAP] provide 'goog.ui.SliderBase.EventType'

[eyakcn]

Currently sliderbase.js does not provide 'goog.ui.SliderBase.EventType', I think this is a mistake.

[nicks]

this guide:
https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone=Providing_Dependencies_With_goog.provide#Providing_Dependencies_With_goog.provide

says not to do this.

in particular, it doesn't make sense to require SliderBase.EventType independently of SliderBase.

[eyakcn]

Really?

goog.provide('goog.ui.SliderBase');
goog.provide('goog.ui.SliderBase.AnimationFactory');
goog.provide('goog.ui.SliderBase.Orientation');

goog.ui.SliderBase.Orientation is also enum, why provided?

Actually I create this issue because there is a third-party tool - fixclosure - which will fix dependencies automatically. My code need to listen to 'goog.ui.SliderBase.EventType.DRAG_VALUE_START', and that tool automatically add
'goog.require('goog.ui.SliderBase.EventType');'.
If you think it's not closure's problem, maybe I need to contact the author of fixclosure.

[nanaze]

Please contact the author of fixclosure. That tool must be aware of what other files are providing.

[eyakcn]

@nanaze I see. Thank you for your answer. But I still want to know why goog.provide('goog.ui.SliderBase.Orientation');

[nicks]

SliderBase.Orientation is provided for legacy reasons.

[eyakcn]

@nicks OK, I got it. Thank you!