New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we get a release? #188
Comments
10 tasks
Ok I'll release tonight
…On Mon, Sep 2, 2019, 10:45 AM Sam Gammon ***@***.***> wrote:
Sorry to file an issue for this, but it would be sweet if we could get a
release cut of Soy.
Upstream, I'm working on integrating SoySauce/SoyTofu into Micronaut (see
micronaut-projects/micronaut-views#13
<micronaut-projects/micronaut-views#13>,
micronaut-projects/micronaut-views#16
<micronaut-projects/micronaut-views#16>).
However, the integration needs patches here in Soy, specifically, #185
<#185> and #186
<#186>, which add the
hasTemplate method.
In any case, those patches are merged, but we don't yet have a release
that contains those (it barely missed the 2019-08-22 release), so we have
to ship a JAR with Micronaut, which is preventing merge of that change.
Thank you in advance for considering my request
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#188?email_source=notifications&email_token=AA2MCG2FLMA2SZRVK5JY6K3QHVGJZA5CNFSM4IS7LZQ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HI2R2FQ>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA2MCG4GHZI6PDEYYIZJJRTQHVGJZANCNFSM4IS7LZQQ>
.
|
@iteriani thank you! you guys rock. happy labor day if you're in the US. |
I believe I released just now. |
@iteriani thank you! |
sgammon
added a commit
to Bloombox/micronaut-views
that referenced
this issue
Sep 4, 2019
Adopts upstream release after request at google/closure-templates#188
sgammon
added a commit
to Bloombox/micronaut-views
that referenced
this issue
Sep 4, 2019
Adopts upstream release after request at google/closure-templates#188
sgammon
added a commit
to Bloombox/micronaut-views
that referenced
this issue
Sep 4, 2019
Adopts upstream release after request at google/closure-templates#188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sorry to file an issue for this, but it would be sweet if we could get a release cut of Soy.
Upstream, I'm working on integrating
SoySauce
/SoyTofu
into Micronaut (see micronaut-projects/micronaut-views#13, micronaut-projects/micronaut-views#16). However, the integration needs patches here in Soy, specifically, #185 and #186, which add thehasTemplate
method.In any case, those patches are merged, but we don't yet have a release that contains those (it barely missed the
2019-08-22
release), so we have to ship a JAR with Micronaut, which is preventing merge of that change. Thank you in advance for considering my requestThe text was updated successfully, but these errors were encountered: