Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we get a release? #188

Closed
sgammon opened this issue Sep 2, 2019 · 4 comments
Closed

Can we get a release? #188

sgammon opened this issue Sep 2, 2019 · 4 comments

Comments

@sgammon
Copy link

sgammon commented Sep 2, 2019

Sorry to file an issue for this, but it would be sweet if we could get a release cut of Soy.

Upstream, I'm working on integrating SoySauce/SoyTofu into Micronaut (see micronaut-projects/micronaut-views#13, micronaut-projects/micronaut-views#16). However, the integration needs patches here in Soy, specifically, #185 and #186, which add the hasTemplate method.

In any case, those patches are merged, but we don't yet have a release that contains those (it barely missed the 2019-08-22 release), so we have to ship a JAR with Micronaut, which is preventing merge of that change. Thank you in advance for considering my request

@iteriani
Copy link
Contributor

iteriani commented Sep 2, 2019 via email

@sgammon
Copy link
Author

sgammon commented Sep 2, 2019

@iteriani thank you! you guys rock. happy labor day if you're in the US.

@iteriani
Copy link
Contributor

iteriani commented Sep 3, 2019

I believe I released just now.

@iteriani iteriani closed this as completed Sep 3, 2019
@sgammon
Copy link
Author

sgammon commented Sep 4, 2019

@iteriani thank you!

sgammon added a commit to Bloombox/micronaut-views that referenced this issue Sep 4, 2019
sgammon added a commit to Bloombox/micronaut-views that referenced this issue Sep 4, 2019
sgammon added a commit to Bloombox/micronaut-views that referenced this issue Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants