Fix possible NullPointerException in SoySyntaxException.associateMetaInfo #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monzonj
changed the title
Closed
|
@monzonj can you point out where the NPE can happen? |
Ubehebe
pushed a commit
that referenced
this pull request
Feb 6, 2015
Cl #6 adds support for the print node. The print node itself is fairly trivial, but this brings in support for the bulk of the low level expression support. Unlike JS, Python syntax has a few fairly fundamental differences from Soy syntax, such as ternary conditional ordering and operator precedence. So, the primary logic focus of this CL lives in TranslateToPyExprVisitor. Print directive and function implementations are left to CL #7. See: [] ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=85578793
Ubehebe
pushed a commit
that referenced
this pull request
Feb 27, 2015
Related Design Doc: [] [] Added support for plural nodes. Though Plural Nodes could be rendered as ICU string which is the case in Java backend, current design has better efficiency. It saves the effort of parsing at runtime. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=87208937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method claims the parameter srcLoc can be null (@nullable) but it will potentially throw and exception if that were the case.