About testOpenPaperTray() and testNoMediaInTray()

[YasuhiroFuruta]

testOpenPaperTray() and testNoMediaInTray() expect that an error icon (red) is displayed on the management page when a tray is open or empty.
However the management page displays a warning icon (yellow) for some printer which can accept jobs in that state.

I think both the error icon and the warning icon should be acceptable in these test cases.

[kdlucas]

I agree. I'll update the tests.

Kelly
kdLucas

On Tue, Jul 26, 2016 at 10:52 PM, YasuhiroFuruta notifications@github.com
wrote:

testOpenPaperTray() and testNoMediaInTray() expect that an error icon
(red) is displayed on the management page when a tray is open or empty.
However the management page displays a warning icon (yellow) for some
printer which can accept jobs in that state.

I think both the error icon and the warning icon should be acceptable in
these test cases.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#53, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ADk_fWxn3clP0nuCFTz6CbTwthrZAZmQks5qZvIIgaJpZM4JV25L
.

[YasuhiroFuruta]

Sorry, I had overlooked about the tray empty state.

When the tray is open, warning icon is displayed in both Printers page and the Printer Details page.
It has been resolved by #55.

However, when the tray is empty, warning icon is displayed only in the Printer Details page.
So testNoMediaInTray() should check the Printer Details page.

[marctan]

I agree with Yasuhiro. This tests also failed on our printers since we report warnings not errors when tray is open and when there's no media in tray.

[kdlucas]

Merged fix with main branch. Hopefully this fixes issues that people have.

[YasuhiroFuruta]

testNoMediaInTray() has not been fixed yet.