Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Allow multiple substitution tokens in additional labels #582

Closed
xenofree opened this issue Mar 29, 2021 · 3 comments
Closed

Allow multiple substitution tokens in additional labels #582

xenofree opened this issue Mar 29, 2021 · 3 comments
Assignees
Milestone

Comments

@xenofree
Copy link

xenofree commented Mar 29, 2021

Hi,

Is there a way to create a label that contains full url of an http probe ?
Something like @target.name@:@target.port@@target.relative_url@

probe {
  name: "http"

  type: HTTP
  targets {
    host_names: "172.18.0.142"
  }
  http_probe {
    port: 8080
    relative_url: "/test"
  }
  interval_msec: 15000 # 15s
  timeout_msec: 5000   # 5s

  additional_label {
    key: "url"
    value: "@target.name@:@target.port@@target.relative_url@" #Should be replaced by 172.18.0.142:8080/test
  }
}
@manugarg
Copy link
Contributor

Yeah, It's not possible to compose labels today. I'll see we can somehow implement it.

@manugarg manugarg added this to the v0.11.3 milestone Jul 16, 2021
@manugarg manugarg changed the title Full url label in HTTP Probe Allow multiple substitution tokens in additional labels Jul 16, 2021
@manugarg manugarg self-assigned this Jul 16, 2021
@manugarg
Copy link
Contributor

I am working on a change to add this feature. I'll submit it in a couple of days.

manugarg added a commit that referenced this issue Jul 20, 2021
This is to support use cases like the one described in:
#582

PiperOrigin-RevId: 385899284
manugarg added a commit that referenced this issue Jul 21, 2021
This is to support use cases like the one described in:
#582

PiperOrigin-RevId: 385899284
manugarg added a commit that referenced this issue Jul 26, 2021
Ref: #582
PiperOrigin-RevId: 386808079
manugarg added a commit that referenced this issue Jul 26, 2021
Ref: #582
PiperOrigin-RevId: 386808079
@manugarg
Copy link
Contributor

manugarg commented Jul 30, 2021

This is now done. Please track the milestone v0.11.3 for release. In the meantime, you can use the docker tag "master" to access the latest changes (or download the latest binaries from the project's Actions page).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants