Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builtins::Lookup interface - phase2 #531

Merged
merged 3 commits into from Mar 23, 2020
Merged

Builtins::Lookup interface - phase2 #531

merged 3 commits into from Mar 23, 2020

Conversation

sjw36
Copy link
Contributor

@sjw36 sjw36 commented Mar 18, 2020

  • Updated usage in SPIRVProducer, replaced StringSwitch
  • Converted SplatArgPass, programmatically generate new function call based on FunctionInfo
  • Converted all ReplaceOpenCLBuiltinPass
    • Iterate once over Module->getFunctionList(), switch on FunctionInfo type
    • Changed all replace methods to create a Replacer lambda
  • Links to Builtin cleanup #510

Builtins::Lookup interface - phase2
378f5a2 
* Updated usage in SPIRVProducer, replaced StringSwitch
* Converted SplatArgPass, programmatically generate new function call based on FunctionInfo
* Converted all ReplaceOpenCLBuiltinPass
  * Iterate once over Module->getFunctionList(), switch on FunctionInfo type
  * Changed all replace methods to create a Replacer lambda
* Links to google#510
@alan-baker alan-baker self-assigned this Mar 18, 2020
@alan-baker alan-baker added this to In progress in General via automation Mar 18, 2020
alan-baker
alan-baker requested changes Mar 20, 2020
View reviewed changes
Copy link
Collaborator

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Looks good, but have a few minor changes.

lib/OpenCLInlinerPass.cpp Outdated Show resolved Hide resolved
lib/ReplaceOpenCLBuiltinPass.cpp Outdated Show resolved Hide resolved
lib/SplatArgPass.cpp Outdated Show resolved Hide resolved
lib/SplatArgPass.cpp Outdated Show resolved Hide resolved
lib/SPIRVProducerPass.cpp Outdated Show resolved Hide resolved
@alan-baker alan-baker merged commit 2c317da into google:master Mar 23, 2020
General automation moved this from In progress to Done Mar 23, 2020
@jrprice jrprice mentioned this pull request Mar 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-baker alan-baker alan-baker approved these changes

@dneto0 dneto0 Awaiting requested review from dneto0

Assignees

@alan-baker alan-baker

Labels
enhancement
Projects
General
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjw36 @alan-baker @kokoro-team