Read WorkgroupSize as whole vector from the spec constant value #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on release and debug builds, and in hardware. |
|
LGTM |
|
No, not so fast. Doesn't work in some scenarios. My HW case wasn't right. |
dneto0
force-pushed
the
read-workgroup-size-as-vector
branch
2 times, most recently
from
324d1b8
to
4e1a86f
Compare
dneto0
changed the title
dneto0
force-pushed
the
read-workgroup-size-as-vector
branch
2 times, most recently
from
ff28a83
to
7f95b43
Compare
|
I did see this bug on NVIDIA, but after filing it their latest drivers have fixed the issue fwiw. |
Change the implementation of the get_local_size implementation to avoid some driver bugs: - One issue is trouble extracting individual elements. It's seems to work better to read the entire vector at once. - Another issue is that we have to extract directly from the spec composite value directly rather than from a variable initialized with that spec constant value.
Take the bitwise-and of the WorkgroupSize spec constant value *with itself* before extracting one of its components. This works around a driver bug. Added a TODO to remove this when we can.
dneto0
force-pushed
the
read-workgroup-size-as-vector
branch
from
7f95b43
to
964b936
Compare
Yes, I had the same experience. |
|
Rebased. I'd like to revisit this hack in the future. |
|
LGTM |
dneto0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the implementation of the get_local_size implementation to
avoid some driver bugs:
work better to read the entire vector at once.
composite value directly rather than from a variable initialized with
that spec constant value.