Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention ${fuzzer_name}.dict and ${fuzzer_name}_seed_corpus.zip in the build pipeline and libFuzzer/AFL docs #62

Closed
Dor1s opened this issue Feb 4, 2019 · 7 comments

Comments

@Dor1s
Copy link
Contributor

Dor1s commented Feb 4, 2019

"If you're setting up a build pipeline for in-process fuzzing, ....."

@jonathanmetzman
Copy link
Collaborator

Should this be documented in the build pipeline doc or the libfuzzer_and_afl doc?

@Dor1s
Copy link
Contributor Author

Dor1s commented Feb 4, 2019

I think some part of it must be in the build pipeline, at least the naming format and the requirement to archive that into the same dir with the fuzzing binary -- just because it totally belongs to the build system. More detail can be added in libfuzzer_and_afl doc, I guess. Some notes about how important those things are?

@jonathanmetzman
Copy link
Collaborator

jonathanmetzman commented Feb 4, 2019

just because it totally belongs to the build system.

I don't really see why, dictionary and seed corpus work just as well with custom builds.
I think it would be best for build pipeline to be solely about continuous building rather than about all things about builds (which is why I cover building targets for AFL and libFuzzer in that doc).

@Dor1s
Copy link
Contributor Author

Dor1s commented Feb 4, 2019

Good point regarding custom builds! Maybe we should have some generic sentence in the build pipeline then, like "Make sure to include all important build artifacts into the archive (e.g. dictionaries or seed corpora [link], some other example [link], etc)"

@Dor1s
Copy link
Contributor Author

Dor1s commented Feb 4, 2019

I just want to make sure people remember this stuff when they write a script / build rule for generating a build archive.

@jonathanmetzman
Copy link
Collaborator

OK sgtm.

@Dor1s Dor1s changed the title Mention ${fuzzer_name}.dict and ${fuzzer_name}_seed_corpus.zip in the build pipeline doc Mention ${fuzzer_name}.dict and ${fuzzer_name}_seed_corpus.zip in the build pipeline and libFuzzer/AFL docs Feb 4, 2019
@jonathanmetzman
Copy link
Collaborator

#96 does this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants