Force update heartbeat at start and end of task. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
inferno-chromium
commented
Feb 6, 2019
inferno-chromium
commented
- Need for local development that does not run heartbeat script.
- Also, instant update of task info when it starts and ends.
|
/gcbrun |
Dor1s
approved these changes
Feb 6, 2019
| @@ -509,8 +509,16 @@ def track_task_start(task, task_duration): | |||
| persistent_cache.set_value(TASK_PAYLOAD_KEY, task.payload()) | |||
| persistent_cache.set_value(TASK_END_TIME_KEY, time.time() + task_duration) | |||
|
|
|||
| # Don't wait on |run_heartbeat|, update task information as soon as it starts. | |||
| from datastore import data_handler | |||
There was a problem hiding this comment.
Why do we import it here and on line 523, instead of importing once at the beginning of the file?
There was a problem hiding this comment.
to avoid circular dependencies.
There was a problem hiding this comment.
@mbarbella-chromium cleaned most of those, do you have ideas on this ? i did this to avoid last minute major refactoring, but tested this with local development server-bot config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.