Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFLite seems to fail to download the latest builds due to "Bad credentials" #91

Closed
evverx opened this issue Mar 26, 2022 · 2 comments · Fixed by google/oss-fuzz#7466
Closed

Comments

@evverx
Copy link
Contributor

evverx commented Mar 26, 2022

I'm not sure why it stopped working but it appears CFLite can no longer download the latest builds. In https://github.com/evverx/elfutils/runs/5702214651?check_suite_focus=true it failed with

2022-03-26T08:44:16.2107609Z 2022-03-26 08:44:16,210 - root - INFO - Trying to reproduce crash using: /tmp/tmpzgptwvca/crash-08b22184029412ff41e6015f42fbe90cc6975aea.
2022-03-26T08:44:16.8321170Z 2022-03-26 08:44:16,831 - root - INFO - Reproduce command returned: 77. Reproducible on /github/workspace/build-out/fuzz-libdwfl.
2022-03-26T08:44:16.8328312Z 2022-03-26 08:44:16,832 - root - INFO - Crash is reproducible.
2022-03-26T08:44:16.8448813Z 2022-03-26 08:44:16,844 - root - INFO - Trying to downloading previous build 10b63c5588bf485cf3143b553fad3a9a7c6012f4.
2022-03-26T08:44:16.8952915Z 2022-03-26 08:44:16,893 - root - ERROR - Request to https://api.github.com/repos/evverx/elfutils/actions/artifacts?per_page=100&page=1 failed. Code: 401. Response: {'message': 'Bad credentials', 'documentation_url': 'https://docs.github.com/rest'}
2022-03-26T08:44:16.8954721Z 2022-03-26 08:44:16,893 - root - ERROR - Could not download build for 10b63c5588bf485cf3143b553fad3a9a7c6012f4 because of: Github API request failed.
2022-03-26T08:44:16.8956014Z 2022-03-26 08:44:16,894 - root - INFO - Trying to downloading previous build 392242e2dbe7beddfee283979a81f50a1bf9f18a.
2022-03-26T08:44:16.9439033Z 2022-03-26 08:44:16,942 - root - ERROR - Request to https://api.github.com/repos/evverx/elfutils/actions/artifacts?per_page=100&page=1 failed. Code: 401. Response: {'message': 'Bad credentials', 'documentation_url': 'https://docs.github.com/rest'}
2022-03-26T08:44:16.9440932Z 2022-03-26 08:44:16,942 - root - ERROR - Could not download build for 392242e2dbe7beddfee283979a81f50a1bf9f18a because of: Github API request failed.
2022-03-26T08:44:16.9442233Z 2022-03-26 08:44:16,942 - root - INFO - Trying to downloading previous build 9166adf346d693ea8f40251c601acd1b95a69d40.
2022-03-26T08:44:16.9958385Z 2022-03-26 08:44:16,994 - root - ERROR - Request to https://api.github.com/repos/evverx/elfutils/actions/artifacts?per_page=100&page=1 failed. Code: 401. Response: {'message': 'Bad credentials', 'documentation_url': 'https://docs.github.com/rest'}
2022-03-26T08:44:16.9960886Z 2022-03-26 08:44:16,994 - root - ERROR - Could not download build for 9166adf346d693ea8f40251c601acd1b95a69d40 because of: Github API request failed.
2022-03-26T08:44:16.9963078Z 2022-03-26 08:44:16,995 - root - INFO - Could not run previous build of target to determine if this code change (pr/commit) introduced crash. Assuming crash was newly introduced.

The latest builds can be found at https://github.com/evverx/elfutils/actions/runs/2041191178

@evverx
Copy link
Contributor Author

evverx commented Mar 27, 2022

I "fixed" it by pointing CFLite to my fork of the clusterfuzzlite action where the latest "run-fuzzers" image was replaced with an image without google/oss-fuzz#7325:

    point run-fuzzers to an image where tokens are passed correctly

diff --git a/actions/run_fuzzers/action.yml b/actions/run_fuzzers/action.yml
index 1c21e9c..306cac9 100644
--- a/actions/run_fuzzers/action.yml
+++ b/actions/run_fuzzers/action.yml
@@ -58,7 +58,7 @@ inputs:
     default: False
 runs:
   using: 'docker'
-  image: 'docker://gcr.io/oss-fuzz-base/clusterfuzzlite-run-fuzzers:v1'
+  image: 'docker://gcr.io/oss-fuzz-base/clusterfuzzlite-run-fuzzers@sha256:71f56768b8b208928f568257d17bc33bbd1657359a126aef01ebbb4974dc5d70'
   env:
     FUZZ_SECONDS: ${{ inputs.fuzz-seconds }}
     MODE: ${{ inputs.mode }}

@jonathanmetzman
Copy link
Collaborator

Lemme look into this, I think we changed this recently.

evverx added a commit to evverx/systemd that referenced this issue Apr 22, 2022
The idea was to catch CFLite regressions but since the action itself
pulls the latest docker images it can't be pinned properly and issues
like google/clusterfuzzlite#91 are going to
pop up anyway. Let's unpin it by analogy with CIFuzz and hope it doesn't
break very often.

Waiting for google/clusterfuzzlite#96
evverx added a commit to evverx/systemd that referenced this issue Apr 22, 2022
The idea was to catch CFLite regressions but since the action itself
pulls the latest docker images it can't be pinned properly and issues
like google/clusterfuzzlite#91 are going to
pop up anyway. Let's unpin it by analogy with CIFuzz and hope it doesn't
break very often.

Waiting for google/clusterfuzzlite#96
evverx added a commit to evverx/systemd that referenced this issue Apr 22, 2022
The idea was to catch CFLite regressions but since the action itself
pulls the latest docker images it can't be pinned properly and issues
like google/clusterfuzzlite#91 are going to
pop up anyway. Let's unpin it by analogy with CIFuzz and hope it doesn't
break very often.

Waiting for google/clusterfuzzlite#96
evverx added a commit to evverx/systemd that referenced this issue Apr 26, 2022
The idea was to catch CFLite regressions but since the action itself
pulls the latest docker images it can't be pinned properly and issues
like google/clusterfuzzlite#91 are going to
pop up anyway. Let's unpin it by analogy with CIFuzz and hope it doesn't
break very often.
evverx added a commit to evverx/systemd that referenced this issue Apr 26, 2022
The idea was to catch CFLite regressions but since the action itself
pulls the latest docker images it can't be pinned properly and issues
like google/clusterfuzzlite#91 are going to
pop up anyway. Let's unpin it by analogy with CIFuzz and hope it doesn't
break very often.
mrc0mmand pushed a commit to systemd/systemd that referenced this issue Apr 26, 2022
The idea was to catch CFLite regressions but since the action itself
pulls the latest docker images it can't be pinned properly and issues
like google/clusterfuzzlite#91 are going to
pop up anyway. Let's unpin it by analogy with CIFuzz and hope it doesn't
break very often.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants