Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete extra files and branches with duplicate docs #50

Closed
mbrukman opened this issue Feb 1, 2019 · 3 comments
Closed

Delete extra files and branches with duplicate docs #50

mbrukman opened this issue Feb 1, 2019 · 3 comments

Comments

@mbrukman
Copy link
Member

mbrukman commented Feb 1, 2019

On the master branch, in the doc top-level directory, there are the following files:

The index.html file appears to have the same content as the top-level README.md file and we should be able to delete it, and the script was only useful for Google Code, so it can go as well.

On the wiki branch, we have the following top-level files:

  • ProjectHome.md: a summary of the project, which already appears in the current top-level README.md
  • cmockery.md: appears to be the same content as README.md, but with some errors in the Markdown formatting

I propose deleting both of the files in the doc directory, as well as both of the files on the wiki branch, which also implies removing the doc directory itself, and deleting the wiki branch itself, as there are no other files remaining in either once we do this cleanup.

@stewartmiles, are you OK with all of the proposed changes above? If so, I'm happy to do them.

@stewartmiles
Copy link
Contributor

@mbrukman yeah this sounds fair.

mbrukman added a commit to mbrukman/cmockery that referenced this issue Feb 18, 2019
One of the files is already represented in the top-level README.md; the
other file is unneeded as we do not convert HTML to/from Markdown
anymore.

Partially addresses issue google#50.
@mbrukman
Copy link
Member Author

Status update:

  • removed extra files on master branch in PR Remove unneeded /doc/* files [skip ci] #52 (awaiting review)
  • protected the master branch on GitHub to prevent branch deletion & direct pushes & require PRs
  • removed the wiki branch entirely

Once PR #52 is merged, this issue can be closed.

@mbrukman
Copy link
Member Author

This issue is now fully fixed and can be closed.

mbrukman added a commit to mbrukman/cmockery that referenced this issue Mar 5, 2019
`doc/index.html` was a stale file, thought to be unused, which was
removed in PR google#52 to fix issue google#50. That PR ended up breaking the build
because the file was actually referenced from `Makefile.in` and
`Makefile.am`.

This fixes issue google#57.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants