This repository has been archived by the owner on Nov 5, 2022. It is now read-only.
Json result storage #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change passes the encoding results from the generation side to the display side as JSON files. All usage of gviz code on the generation side is no longer needed. Note: This is a transition CL - the generation side will be able to generate both the old way and the new way until the new way works better than the old way.
Changed the overshoot rule in cpu/rate to be 0.1 dB per percent overshoot, rather than 0.1 dB per kbit/sec overshoot, which increased sanity of VP9 displays. Added in display of command lines as part of the results shown. Added in generation of new-style links in the index pages.
|
@louquillio can you look at the style application functions and Javascript? |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| # A JSON-generating codec comparision tool. |
No support for the theory that "comparision" is a valid spelling found. Also fixing one pylint error.
|
PTAL |
| @@ -440,6 +445,10 @@ def Execute(self, bitrate, videofile, workdir): | |||
| return self.context.codec.Execute( | |||
| self.parameters, bitrate, videofile, workdir) | |||
|
|
|||
| def EncodeCommandLine(self, bitrate, videofile, workdir): | |||
| return self.context.codec.EncodeCommandLine( | |||
| self.parameters, bitrate, videofile, workdir) | |||
There was a problem hiding this comment.
Nit: should indent two more when breaking in an invocation
|
lgtm for python parts |
alvestrand
force-pushed
the
json-result-storage
branch
from
a887e76
to
0920c19
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesigning the interface between the website parts and the Python backend parts to interchange JSON files instead of generating HTML files.
This makes for a simpler system, where display is handled on the display side, and only data is handled on the backend side.