fa: add Persian/Farsi language #1042

DannyRavi · 2023-07-30T22:24:51Z

A simple start to add Persian language to "comprehensive-rust" book

Part of #671.

google-cla · 2023-07-30T22:24:55Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mgeisler · 2023-07-31T13:13:20Z

Hi @DannyRavi, thanks for getting this started! I updated the PR description to mention #671 — if you do that in the coming PRs, then they'll automatically be listed on that issue.

We can merge this when you sign the CLA.

DannyRavi

Partial translation to Farsi

theme/index.hbs

mgeisler · 2023-08-07T07:54:15Z

theme/index.hbs

@@ -1,5 +1,5 @@
 <!DOCTYPE HTML>
-<html lang="{{ language }}" class="sidebar-visible no-js {{ default_theme }}">
+<html lang="{{ language }}"  class="sidebar-visible no-js {{ default_theme }}">


Thanks for the revert — let's also take out the extra space so that the file is completely untouched 😄

Suggested change

<html lang="{{ language }}" class="sidebar-visible no-js {{ default_theme }}">

<html lang="{{ language }}" class="sidebar-visible no-js {{ default_theme }}">

rbehjati · 2023-08-08T07:38:31Z

po/fa.po

+
+#: src/SUMMARY.md:10
+msgid "Rust Ecosystem"
+msgstr "اکو سیستم Rsut"


Suggested change

msgstr "اکو سیستم Rsut"

msgstr "اکوسیستم Rsut"

rbehjati · 2023-08-08T07:39:02Z

po/fa.po

+
+#: src/SUMMARY.md:20
+msgid "What is Rust?"
+msgstr "زبان رااست چیه؟"


Suggested change

msgstr "زبان رااست چیه؟"

msgstr "زبان رااست چیست؟"

rbehjati · 2023-08-08T07:39:21Z

po/fa.po

+
+#: src/SUMMARY.md:22
+msgid "Small Example"
+msgstr "یه مثال ساده"


Suggested change

msgstr "یه مثال ساده"

msgstr "یک مثال ساده"

rbehjati · 2023-08-08T07:41:14Z

po/fa.po

+
+#: src/SUMMARY.md:23
+msgid "Why Rust?"
+msgstr "چرا رااست؟"


Suggested change

msgstr "چرا رااست؟"

msgstr "چرا Rust؟"

To be consistent , since you have not written Rust in Persian alphabet.

rbehjati · 2023-08-08T07:43:13Z

po/fa.po

+
+#: src/SUMMARY.md:32
+msgid "Slices"
+msgstr "برش‌ها"


I suggest adding Slice in parenthesis, unless برش‌ is a familiar term for software engineers.

rbehjati · 2023-08-08T08:06:48Z

po/fa.po

+
+#: src/SUMMARY.md:143
+msgid "From and Into"
+msgstr "از و به داخل"


Don't translate these. These are trait names.

rbehjati · 2023-08-08T08:07:16Z

po/fa.po

+
+#: src/SUMMARY.md:144
+msgid "Read and Write"
+msgstr "خواندن و نوشتن"


Again, trait names. Don't translate. The same applies to Drop and Default.

rbehjati · 2023-08-08T08:10:04Z

po/fa.po

+
+#: src/SUMMARY.md:158
+msgid "Propagating Errors with ?"
+msgstr "انتشار خطاها با چه روشی؟"


"?" is an operator.

Suggested change

msgstr "انتشار خطاها با چه روشی؟"

msgstr "انتشار خطاها با استفاده از عملگر ؟"

rbehjati · 2023-08-08T08:11:23Z

po/fa.po

+
+#: src/SUMMARY.md:168
+msgid "Integration Tests"
+msgstr "تست های یک پارچه"


I am not sure this is the correct translation.

rbehjati · 2023-08-08T08:11:48Z

po/fa.po

+
+#: src/SUMMARY.md:170
+msgid "Unsafe Rust"
+msgstr "رااست ناامن"


Don't translate this.

Thanks for your suggestions.
All suggestions have been made.

rbehjati · 2023-08-08T08:17:31Z

@DannyRavi Thanks for taking the initiative. I have left some comments, but I did not get to go through the entire translation. Can you split this PR into smaller ones? That way it will be a lot easier to review it.

mgeisler · 2023-08-08T08:40:30Z

@DannyRavi Thanks for taking the initiative. I have left some comments, but I did not get to go through the entire translation. Can you split this PR into smaller ones? That way it will be a lot easier to review it.

Thanks a lot @rbehjati! @DannyRavi, I reached out internally to see if I could find someone speaking Persian to skim over the PR.

The test output says

303 translated messages, 1 fuzzy translation, 1466 untranslated messages.

So most of the file is just empty — as expected since this is the initial import. @DannyRavi I suggest you commit the suggestions by @rbehjati and avoid adding more strings to the file just now. We need to get it committed first so that you and others can update it in smaller PRs going forward. A PR per file or top-level directory can work well.

@rbehjati if the PR looks okay, then I suggest we merge it ASAP and move onto smaller PRs going forward.

rbehjati

Thanks. I had a quick look at the rest of the translation and it generally looks good to me.

I see that translating Box and Crate is becoming tricky. My general advice is to keep the original English words for keywords and first class concepts of the language. Learners will eventually want to write code, and knowing the original English words will make that easier for them.

mgeisler · 2023-08-09T08:21:14Z

My general advice is to keep the original English words for keywords and first class concepts of the language. Learners will eventually want to write code, and knowing the original English words will make that easier for them.

I know that some other translations have kept the English word as well — and some have added it in parenthesis after the translation. I'm happy with either approach. You could consider starting a discussion about it to hear what others think.

rbehjati · 2023-08-09T08:59:00Z

I know that some other translations have kept the English word as well — and some have added it in parenthesis after the translation. I'm happy with either approach. You could consider starting a discussion about it to hear what others think.

Thanks. I think in some cases it is good to have a translation, with the original English word in parenthesis, but sometimes it is better to avoid a translation all together (unless it is for fun ;)). I leave it to @DannyRavi to start a discussion.

* A partial translation into Farsi

DannyRavi added 2 commits July 31, 2023 01:25

add persian/farsi language

50fcb05

small change in translate of one word

6c6b279

github-actions bot added the translation label Jul 30, 2023

mgeisler changed the title ~~add Persian/Farsi language to comprehensive-rust~~ fa: add Persian/Farsi language Jul 31, 2023

mgeisler mentioned this pull request Jul 31, 2023

Persian translation #671

Open

another step tp traslate rust book to farsi

e0ea114

DannyRavi commented Aug 5, 2023

View reviewed changes

mgeisler reviewed Aug 7, 2023

View reviewed changes

theme/index.hbs Outdated Show resolved Hide resolved

DannyRavi added 2 commits August 7, 2023 11:18

Merge branch 'google:main' into main

94715e1

remove rtl frome index.hbs

70a4f41

mgeisler reviewed Aug 7, 2023

View reviewed changes

DannyRavi added 3 commits August 7, 2023 11:34

remoce extra space in index.hbs

097d786

Merge branch 'google:main' into main

5bfd64e

A partial translation into Farsi.

2728b82

rbehjati reviewed Aug 8, 2023

View reviewed changes

Editing of some Persian translations

da7de17

rbehjati approved these changes Aug 8, 2023

View reviewed changes

rbehjati merged commit c674d39 into google:main Aug 9, 2023
30 checks passed

yohcop pushed a commit to yohcop/comprehensive-rust that referenced this pull request Sep 12, 2023

fa: Add Persian/Farsi language (google#1042)

d3fcf8e

* A partial translation into Farsi

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fa: add Persian/Farsi language #1042

fa: add Persian/Farsi language #1042

DannyRavi commented Jul 30, 2023 •

edited by mgeisler

google-cla bot commented Jul 30, 2023

mgeisler commented Jul 31, 2023

DannyRavi left a comment

mgeisler Aug 7, 2023

rbehjati Aug 8, 2023

rbehjati Aug 8, 2023

rbehjati Aug 8, 2023

rbehjati Aug 8, 2023

rbehjati Aug 8, 2023

rbehjati Aug 8, 2023

rbehjati Aug 8, 2023

rbehjati Aug 8, 2023

rbehjati Aug 8, 2023

rbehjati Aug 8, 2023

DannyRavi Aug 8, 2023 •

edited

rbehjati commented Aug 8, 2023

mgeisler commented Aug 8, 2023

rbehjati left a comment

mgeisler commented Aug 9, 2023

rbehjati commented Aug 9, 2023

	<html lang="{{ language }}" class="sidebar-visible no-js {{ default_theme }}">
	<html lang="{{ language }}" class="sidebar-visible no-js {{ default_theme }}">

	msgstr "اکو سیستم Rsut"
	msgstr "اکوسیستم Rsut"

	msgstr "زبان رااست چیه؟"
	msgstr "زبان رااست چیست؟"

	msgstr "یه مثال ساده"
	msgstr "یک مثال ساده"

	msgstr "انتشار خطاها با چه روشی؟"
	msgstr "انتشار خطاها با استفاده از عملگر ؟"

fa: add Persian/Farsi language #1042

fa: add Persian/Farsi language #1042

Conversation

DannyRavi commented Jul 30, 2023 • edited by mgeisler

google-cla bot commented Jul 30, 2023

mgeisler commented Jul 31, 2023

DannyRavi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DannyRavi Aug 8, 2023 • edited

Choose a reason for hiding this comment

rbehjati commented Aug 8, 2023

mgeisler commented Aug 8, 2023

rbehjati left a comment

Choose a reason for hiding this comment

mgeisler commented Aug 9, 2023

rbehjati commented Aug 9, 2023

DannyRavi commented Jul 30, 2023 •

edited by mgeisler

DannyRavi Aug 8, 2023 •

edited