Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fa: Add more Persian translations #1341

Closed
wants to merge 15 commits into from
Closed

fa: Add more Persian translations #1341

wants to merge 15 commits into from

Conversation

javad-jafari
Copy link
Collaborator

@javad-jafari javad-jafari commented Oct 10, 2023

Part of #671.

@google-cla
Copy link

google-cla bot commented Oct 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
@javad-jafari
Copy link
Collaborator Author

What is the problem with line 1027 po/fa.po ?!

@mgeisler
Copy link
Collaborator

What is the problem with line 1027 po/fa.po ?!

The problem is that the wrapping changed. Can you please merge in the latest main, and then read about dprint fmt in TRANSLATIONS?

I just updated that file with instructions for how to auto-format the PO files. In short, you need to

  • Merge in the latest main.
  • Install dprint.
  • Install msgcat: sudo apt install gettext on a Debian system.
  • Run dprint fmt.
  • Commit the result and push it to your branch.

Comment on lines -1027 to +1029
"[![Build workflow](https://img.shields.io/github/actions/workflow/status/"
"google/comprehensive-rust/build.yml?style=flat-square)](https://github.com/"
"google/comprehensive-rust/actions/workflows/build.yml?query=branch%3Amain)"
"[![Build workflow](https://img.shields.io/github/actions/workflow/status/google/"
"comprehensive-rust/build.yml?style=flat-square)](https://github.com/google/"
"comprehensive-rust/actions/workflows/build.yml?query=branch%3Amain)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the kind of change that should not happen. If you install dprint and the Gettext tools, you can run dprint fmt to fix it.

@mgeisler mgeisler changed the title Some Persian translation has been added. fa: Add more Persian translations Oct 14, 2023
@mgeisler mgeisler mentioned this pull request Oct 16, 2023
@mgeisler
Copy link
Collaborator

Hi @javad-jafari, please add Part of #671. to the commit messages (or PR description) — that way the PR will show up on #671, which is the tracking issue for Persian.

Also, please say hello to @DannyRavi and @mbpouri there — they are two other volunteers who are interested in this translation. I'll try to find more people who can help out, but the three of you should coordinate with each other for now.

@DannyRavi
Copy link
Collaborator

Hi @mgeisler.
I am very happy to collaborate with other people @javad-jafari and @mbpouri for Persian translation or review in this project.

@mgeisler
Copy link
Collaborator

Hi @mgeisler. I am very happy to collaborate with other people @javad-jafari and @mbpouri for Persian translation or review in this project.

Awesome! Can you start by reading through the changes here and add GitHub suggestions for anything you think should be fixed? @henrif75 will invite you and the others to work on the repository so that you can approve PRs without having to rely on me.

@mgeisler
Copy link
Collaborator

@javad-jafari, you should run dprint fmt on your checkout to fix the formatting errors.

@DannyRavi
Copy link
Collaborator

Hi @mgeisler. I am very happy to collaborate with other people @javad-jafari and @mbpouri for Persian translation or review in this project.

Awesome! Can you start by reading through the changes here and add GitHub suggestions for anything you think should be fixed? @henrif75 will invite you and the others to work on the repository so that you can approve PRs without having to rely on me.

It's awesome, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants