Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fa: Adding Persian translations to side bar items #1427

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

moaminsharifi
Copy link
Collaborator

Part of #671
Summary of changes:

  • persian version of book messages synced to orginal book
  • Translate sidebar menu
    for making easier for Reviewers, I just translate and double check until # src/SUMMARY.md:333 part

Suggestions:
1- Convert "منابع" to "حافظه" for Rust Memory Management

#: src/SUMMARY.md:88
msgid "Rust Memory Management"
msgstr "مدیریت منابع Rust"

In the Persian Computer community when we call "Memory" is "حافظه"

Plus, in other places translted to "حافظه"

#: src/SUMMARY.md:85 src/memory-management/manual.md:1
msgid "Manual Memory Management"
msgstr "مدیریت دستی حافظه"

@mgeisler
Copy link
Collaborator

Hi @moaminsharifi, in case you didn't notice: msgmerge moved a bunch of translations to a kind of "paper bin" at the end of the PO file:

@@ -21004,3 +19937,150 @@ msgid ""
 "}\n"
 "```"
 msgstr ""
+
+#~ msgid "Comparison"
+#~ msgstr "مقایسه"

You should delete them when you think they're no longer useful — the code blocks found there are no longer useful and should just go away now.

@mgeisler
Copy link
Collaborator

Also, I'll unassign myself as a reviewer — I cannot actually help with the content here and you have to self-organize to make this scale 🙂

@mgeisler mgeisler removed their request for review October 25, 2023 12:45
@hamidrezakp
Copy link
Collaborator

Also, I'll unassign myself as a reviewer — I cannot actually help with the content here and you have to self-organize to make this scale 🙂

Sure, Thank you 👍🏻

Copy link
Collaborator

@hamidrezakp hamidrezakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, Thank you for your time taken to translate this part.
The diff is so big that Github can't show it to me, so i will comment the suggestion here for you.

Some of them are related to ZWNJ and some for previous translation.

  • "Compile Time Guarantees" => "ضمانت‌های زمان کامپایل"
  • "Runtime Guarantees" => "ضمانت‌های زمان اجرا"
  • "Scalar Types" => "تایپ‌های عددی"
  • "Compound Types" => "تایپ‌های مرکب "
  • "Rustdoc" => "مستند نویسی"
  • "Type Inference" => "تعیین تایپ ضمنی"
  • "Move Semantics" => "مفاهیم جا‌به‌جایی"
  • "Moves in Function Calls" => "جابه‌جایی در صدا زدن توابع"
  • "Lifetimes in Function Calls" => "طول عمر در فراخوانی‌ توابع"
  • "Panics" => "پنیک‌ها"
  • "Generics" => "جنریک‌ها"
  • "Filesystem Hierarchy" => "سلسله‌ مراتب فایل‌سیستم"
  • "Tuple Structs" => "ساختار‌های چند‌گانه (Tuple Structs)"

@moaminsharifi
Copy link
Collaborator Author

moaminsharifi commented Oct 25, 2023

First off, Thank you for your time taken to translate this part. The diff is so big that Github can't show it to me, so i will comment the suggestion here for you.

Some of them are related to ZWNJ and some for previous translation.

  • "Compile Time Guarantees" => "ضمانت‌های زمان کامپایل"
  • "Runtime Guarantees" => "ضمانت‌های زمان اجرا"
  • "Scalar Types" => "تایپ‌های عددی"
  • "Compound Types" => "تایپ‌های مرکب "
  • "Rustdoc" => "مستند نویسی"
  • "Type Inference" => "تعیین تایپ ضمنی"
  • "Move Semantics" => "مفاهیم جا‌به‌جایی"
  • "Moves in Function Calls" => "جابه‌جایی در صدا زدن توابع"
  • "Lifetimes in Function Calls" => "طول عمر در فراخوانی‌ توابع"
  • "Tuple Structs" => "ساختار‌های تاپل‌ای"
  • "Panics" => "پنیک‌ها"
  • "Generics" => "جنریک‌ها"
  • "Filesystem Hierarchy" => "سلسله‌ مراتب فایل‌سیستم"
  • "Tuple Structs" => "ساختار‌های چند‌گانه (Tuple Structs)"

I update most of them as you suggested.
About "Panics" in persian we call it "وحشت زدگی" or "پانیک"
Also "Half-space" fixed in summary part

@moaminsharifi
Copy link
Collaborator Author

Hi @moaminsharifi, in case you didn't notice: msgmerge moved a bunch of translations to a kind of "paper bin" at the end of the PO file:

@@ -21004,3 +19937,150 @@ msgid ""
 "}\n"
 "```"
 msgstr ""
+
+#~ msgid "Comparison"
+#~ msgstr "مقایسه"

You should delete them when you think they're no longer useful — the code blocks found there are no longer useful and should just go away now.

I deleted all of them, thanks for mention it.

Copy link
Collaborator

@hamidrezakp hamidrezakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

@hamidrezakp hamidrezakp merged commit 629a5c3 into google:main Oct 25, 2023
31 checks passed
@mgeisler
Copy link
Collaborator

Just in case you haven't seen it: the translation here also refreshes the messages to include the latest and greatest changes from the English text. I see this because of

 msgid ""
 msgstr ""
 "Project-Id-Version: Comprehensive Rust 🦀\n"
-"POT-Creation-Date: 2023-08-23\n"
+"POT-Creation-Date: 2023-10-25T14:05:24+03:30\n"
 "PO-Revision-Date: 2023-08-08 21:41+0330\n"
 "Last-Translator: danny <danykhosravi@gmail.com>\n"
 "Language-Team: Persian\n"

This explains why the diff is so large, but it's all good.

Just be aware that you shouldn't do a msgmerge with every PR — at least not when the translation is still young and incomplete. I recommend working towards a full translation of Day 1 to 3 and then do another refresh then.

Until you refresh, the translation will stay frozen: we git restore the English files back to the timestamp in POT-Creation-Date when publishing and this ensures you have a stable ground to work from.

Another good side-effect of only doing msgmerge once in a while is that the next PRs will be smaller: they will only add text instead of shuffling things around like this PR does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants