Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fa: Translate Part 3 , 4 , 5 ,6.1, 6.2, 6.3 #1439

Merged
merged 10 commits into from
Nov 4, 2023

Conversation

moaminsharifi
Copy link
Collaborator

Part of #671
Summary of changes:

  • Translate Part 3 , 4 , 5 ,6.1, 6.2, 6.3
    for making easier for Reviewers, I just translate until #: src/basic-syntax/references.md:3

I manage to handle all of ltr textes between in rtl texts which have bidi issue:

for example:

  • ++C instead of C++
  • !println instead of println!
    2023-10-31 16_05_45-سلام دنیا - Comprehensive Rust 🦀
    Or:

2023-10-31 15_11_38-تایپ‌های عددی - Comprehensive Rust 🦀
which is so messy in the table, and now is:
2023-10-31 16_14_07-تایپ‌های عددی - Comprehensive Rust 🦀

Thanks to @mgeisler for checking and merging pull request #1433, the changes have greatly improved BiDi in the project.

@hamidrezakp hamidrezakp reopened this Oct 31, 2023
Copy link

@prmadev prmadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not go further than line 2426 at the moment. But for now, here are some of my comments.

po/fa.po Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Show resolved Hide resolved
po/fa.po Show resolved Hide resolved
po/fa.po Show resolved Hide resolved
po/fa.po Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
@DannyRavi
Copy link
Collaborator

Thanks to @moaminsharifi for translating some of the texts.

moaminsharifi and others added 5 commits October 31, 2023 23:23
Co-authored-by: Kaveh <hamidrkp@riseup.net>
Co-authored-by: Kaveh <hamidrkp@riseup.net>
Copy link
Collaborator

@hamidrezakp hamidrezakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the size of comments, a lot of them are ZWNJ's.

Thank you again, great work.

po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
po/fa.po Outdated Show resolved Hide resolved
moaminsharifi and others added 2 commits November 4, 2023 12:18
Co-authored-by: Kaveh <hamidrkp@riseup.net>
Copy link
Collaborator

@hamidrezakp hamidrezakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hamidrezakp hamidrezakp merged commit 9ddc51a into google:main Nov 4, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants