Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include notes on when to use lifetime annotations #1616

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Include notes on when to use lifetime annotations #1616

merged 1 commit into from
Dec 31, 2023

Conversation

djmitche
Copy link
Collaborator

This addresses

Could use more clarity on why or when people would want to use lifetimes -- when is it worth going to the trouble of not Cloning, etc.

in #1565.

mgeisler
mgeisler approved these changes Dec 31, 2023
View reviewed changes
Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like this brief explanation.

@djmitche djmitche merged commit 09aa70b into google:main Dec 31, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgeisler mgeisler mgeisler approved these changes

@marshallpierce marshallpierce Awaiting requested review from marshallpierce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djmitche @mgeisler