Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused main() function in day-2.morning exercise. #347

Closed
wants to merge 1 commit into from

Conversation

gendx
Copy link
Collaborator

@gendx gendx commented Feb 3, 2023

This exercise is about making the unit tests pass, so we can remove the main() function, which is empty and unused. Otherwise the Rust playground complains about dead code.

@gendx gendx marked this pull request as draft February 6, 2023 16:44
@gendx
Copy link
Collaborator Author

gendx commented Feb 6, 2023

Looks like the cargo build check is not happy about that.

@mgeisler
Copy link
Collaborator

mgeisler commented Feb 9, 2023

Looks like the cargo build check is not happy about that.

Yeah, it's probably listed as a binary in the Cargo.toml file and so the build breaks without a main.

@mgeisler
Copy link
Collaborator

mgeisler commented Feb 9, 2023

We could unlist it there if it's covered equivalently by mdbook test.

@mgeisler
Copy link
Collaborator

mgeisler commented Nov 2, 2023

This looks a bit stale — we can revisit it after #1073 is merged.

@mgeisler mgeisler closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants