Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about hygienic macros #472

Merged
merged 3 commits into from Mar 3, 2023
Merged

Add note about hygienic macros #472

merged 3 commits into from Mar 3, 2023

Conversation

qwandor
Copy link
Collaborator

@qwandor qwandor commented Mar 2, 2023

No description provided.

mgeisler
mgeisler approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure — I hope someone will come by and help explain why the macros are only partially hygenic. The sentence seems to be begging for some further explanations (perhaps a link to somewhere?)

@qwandor
Copy link
Collaborator Author

qwandor commented Mar 3, 2023

Added a link.

@qwandor qwandor enabled auto-merge (squash) March 3, 2023 12:18
@qwandor qwandor merged commit a78d58b into main Mar 3, 2023
@qwandor qwandor deleted the qwandor-patch-1 branch March 3, 2023 12:19
NoahDragon pushed a commit to wnghl/comprehensive-rust that referenced this pull request Jul 19, 2023
@qwandor @NoahDragon
Add note about hygienic macros (google#472)
1336144 
* Add note about hygienic macros

* Fix typo.

* Add link about macro hygiene.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgeisler mgeisler mgeisler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qwandor @mgeisler