-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ja: Translate Chapter 2 #766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull requests! Here are my comments
as per @keiichiw
as per @chikoski comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CoinEZ-JPN Would you please merge the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing because “
and ”
are used instead of "
.
Can you fix it?
po/ja.po
Outdated
"\n" | ||
" ```rust\n" | ||
" fn main() {\n" | ||
" println!(“Edit me!”);\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, “
and ”
are used instead of "
. (U+201C, U+201D v.s. U+0022)
This caused a build error on the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
pls note: I edited directly on ja.po as poedit was automatically rewriting;
"Edit me!" to “Edit me!”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgeisler Just FYI, it seems that poedit automatically rewrote double quotes. Did you encounter this issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be more accurate, the app seems to overwrite when the code block is part of a larger chunk to translate
i.e. the same code in Ch.2.2, which I left untranslated, works as expected
FYI - adding \
in front/after the "
does NOT work for me, .po
needed to be updated directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgeisler Just FYI, it seems that poedit automatically rewrote double quotes. Did you encounter this issue?
Not me personally, but people reported this in the past. There is a setting somewhere that let's you turn it off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that! I've quoted this in #800 and will refer others to that post in the future!
edited directly on ja.po instead of poedit, as copy&paste in the tool auto-converted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Sections 0, 1, 2, and 3
Part of #652.