Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ja: Translate Chapter 2 #766

Merged
merged 8 commits into from
Jun 6, 2023
Merged

Conversation

CoinEZ-JPN
Copy link
Contributor

@CoinEZ-JPN CoinEZ-JPN commented Jun 4, 2023

Sections 0, 1, 2, and 3

  • embedded playground = 組み込まれたプレイグラウンド(?)
  • NOTE: Ch2.3 "With this in place, follow these steps to build a Rust binary from one of the examples in this training:" not reflected to Japanese

Part of #652.

po/ja.po Outdated Show resolved Hide resolved
po/ja.po Outdated Show resolved Hide resolved
po/ja.po Outdated Show resolved Hide resolved
po/ja.po Outdated Show resolved Hide resolved
po/ja.po Outdated Show resolved Hide resolved
po/ja.po Outdated Show resolved Hide resolved
po/ja.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@keiichiw keiichiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull requests! Here are my comments

po/ja.po Outdated Show resolved Hide resolved
po/ja.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@chikoski chikoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CoinEZ-JPN Would you please merge the PR?

Copy link
Collaborator

@keiichiw keiichiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing because and are used instead of ".
Can you fix it?

po/ja.po Outdated
"\n"
" ```rust\n"
" fn main() {\n"
" println!(“Edit me!”);\n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, and are used instead of ". (U+201C, U+201D v.s. U+0022)
This caused a build error on the CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

pls note: I edited directly on ja.po as poedit was automatically rewriting;
"Edit me!" to “Edit me!”

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgeisler Just FYI, it seems that poedit automatically rewrote double quotes. Did you encounter this issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be more accurate, the app seems to overwrite when the code block is part of a larger chunk to translate
i.e. the same code in Ch.2.2, which I left untranslated, works as expected

FYI - adding \ in front/after the " does NOT work for me, .po needed to be updated directly

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgeisler Just FYI, it seems that poedit automatically rewrote double quotes. Did you encounter this issue?

Not me personally, but people reported this in the past. There is a setting somewhere that let's you turn it off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

morning, just sharing in case it may help others with similar issues;

  • auto-conversion is a Mac setting
  • to disable, follow these steps;
  1. Open poedit
  2. Go to Edit > Substitutions
  3. Uncheck "Smart Quotes"
    Note: the focus may need to be in the "Translation" section to see toggle enabled
Screenshot 2023-06-11 at 10 52 25

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that! I've quoted this in #800 and will refer others to that post in the future!

edited directly on ja.po instead of poedit, as copy&paste in the tool auto-converted
Copy link
Collaborator

@keiichiw keiichiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@keiichiw keiichiw merged commit c0f84d0 into google:main Jun 6, 2023
24 checks passed
@mgeisler mgeisler changed the title Japanese translation ch 2 #652 ja: Translate Chapter 2 Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants