-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
it: update translation #974
Conversation
- MDBOOK_OUTPUT='{"xgettext": {"pot-file": "messages.pot"}}' \ mdbook build -d po - msgmerge --update po/it.po po/messages.pot
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@henrythebuilder thank you for this, it's quite long so it's going to take a while for me to go through it, so bear with me. Meanwhile, could you please go through the CLA process? Please see https://github.com/google/comprehensive-rust/pull/974/checks?check_run_id=15059836270 |
Thanks for response. |
The changes seem to be many but it should be kept in mind that some have remained the same and others have only been modified in part. It should be noted that the initial refresh procedure ('Generating the PO Template' + 'Refreshing an Existing Translation') modified the initial file on which I worked. |
@detro, just in case you haven't seen it: you can review the commits one-by-one and then you get the changes are much more manageable: |
Need help: edit: I made a new commit in the 'it-translation' branch as fix attempts! |
PR run failed: Test, Attempt #2 - it: update translation (9496e96): https://github.com/google/comprehensive-rust/actions/runs/5544681099
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent @henrythebuilder. Thank you so much for doing this, and thanks for partitioning your work into manageable commits, so to make the review easier.
I have mostly found a few typos and maybe one or two suggestions: should be easy to address or tweak.
In regards to the error you got:
'msgid' and 'msgstr' entries do not both end with '\n'
I admit I'm very much new to the .po
format, and I leave it to @mgeisler to suggest if the workaround you put in place is the right one. But I do agree with you that it seems odd and might end up with odd formatting (i.e. line breaks where they are not needed).
Anyway, once those small issues are solved, I'd be happy to approve.
Thanks again for this.
I updated the branch henrythebuilder:it-translation! |
Thanks |
Thank You Enrico ;) |
@henrif75 is now helping with all things related to the translations. Here, the problem is that source text ( |
* Updating 'it' Translation - MDBOOK_OUTPUT='{"xgettext": {"pot-file": "messages.pot"}}' \ mdbook build -d po - msgmerge --update po/it.po po/messages.pot * it: summary * it: welcome * it: 'Running the Course' * it: using cargo * it: Day 1 - Morning * it: Fix attempt to resolve errors for the PR integration: PR run failed: Test, Attempt google#2 - it: update translation (9496e96): https://github.com/google/comprehensive-rust/actions/runs/5544681099 * Minor fixes validated with @detro for PR merge (google#974)
Context: #537
Update the Italian translation (po/it.po) from latest source and update first three sections:
Enrico