Bump Java language level to 1.8. #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only affects non-Android builds. Android builds are still desugared to be compatible with 1.7 by the SDK in order to run on older desserts. We announced in the last release that we would be dropping support for 1.7. Note that the Android-Stub build config previously had a comment that it needed to be binary compatible with Android minSdkVersion. That was erroneous, it's used for non-Android builds and so should shouldn't redefine the source or target language level. Tested: ./gradlew check ./gradlew conscrypt-android:check
Yqwed
approved these changes
Jul 15, 2021
|
Woot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only affects non-Android builds. Android builds are still desugared
to be compatible with 1.7 by the SDK in order to run on older desserts.
We announced in the last release that we would be dropping support for 1.7.
Note that the Android-Stub build config previously had a comment that
it needed to be binary compatible with Android minSdkVersion. That
was erroneous, it's used for non-Android builds and so should shouldn't
redefine the source or target language level.
Tested:
./gradlew check
./gradlew conscrypt-android:check